Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing cordinator write metrics on C*3 #63

Open
serban21 opened this issue Feb 13, 2020 · 0 comments · May be fixed by #65
Open

Missing cordinator write metrics on C*3 #63

serban21 opened this issue Feb 13, 2020 · 0 comments · May be fixed by #65

Comments

@serban21
Copy link

  1. CoordinatorWriteLatency is not available as a table metric until C*4 (see https://issues.apache.org/jira/browse/CASSANDRA-14232 and apache/cassandra@d38694a). And it's not included anyway in cassandra exporter.
  2. At https://github.com/instaclustr/cassandra-exporter/blob/master/common/src/main/java/com/zegelin/cassandra/exporter/FactoriesSupplier.java#L202-L203 write is not included for null consistency. But in C*3 I only get null consistency, and as described above we don't have table metric to do a total on.

Fix:

  1. Add CoordinatorWriteLatency, prepare for C*4.
  2. Include write when consistency is null

I'll push a PR soon for this. I encountered another issue when testing with C*4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send writes without consistency due to missing coordinator write metr… serban21/cassandra-exporter
1 participant
@serban21