Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not applying vulnerability_alerts = true on private repository creation #754

Closed
cgriego opened this issue Apr 6, 2021 · 5 comments
Closed
Labels
Status: Stale Used by stalebot to clean house

Comments

@cgriego
Copy link

cgriego commented Apr 6, 2021

Terraform Version

Terraform v0.13.6
+ provider registry.terraform.io/integrations/github v4.5.0

Affected Resource(s)

  • github_repository

Terraform Configuration Files

resource "github_repository" "simulator" {
  visibility = "private"
  name       = "simulator"

  delete_branch_on_merge = true
  has_issues             = false
  has_projects           = false
  has_wiki               = false
  vulnerability_alerts   = true
}

Expected Behavior

When initially creating the resource, vulnerability alerts should be enabled.

Actual Behavior

Repository is initially created with vulnerability alerts disabled, and running Terraform again enables the vulnerability alerts.

Steps to Reproduce

  1. terraform apply
@kfcampbell
Copy link
Member

I've confirmed this behavior and drafted a PR to fix it. I'll see about investigating any possible side effects more thoroughly and try to resolve the issue!

@ppferrari
Copy link

Hi @kfcampbell,
will your fix help in some way with this too?

@kfcampbell
Copy link
Member

@ppferrari I don't believe so. I've asked around internally and it looks like that has a separate API. I'll make a comment to that effect over there. If nobody beats me to it, I can take a peek at that issue once this fix is in.

@github-actions
Copy link

github-actions bot commented Dec 3, 2022

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Dec 3, 2022
@kfcampbell
Copy link
Member

Closing as #768 has been merged. Please open a new issue if there's additional behavior around vulnerability alerts that should be changed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Used by stalebot to clean house
Projects
None yet
Development

No branches or pull requests

3 participants