Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI detection for database migration issues #1311

Closed
mxsasha opened this issue Mar 7, 2024 · 2 comments · Fixed by #1379
Closed

Improve CI detection for database migration issues #1311

mxsasha opened this issue Mar 7, 2024 · 2 comments · Fixed by #1379

Comments

@mxsasha
Copy link
Collaborator

mxsasha commented Mar 7, 2024

If migrations cause a migration conflict, the testing parts of the build just hang forever with no clear output, e.g. here. Perhaps an easy fix is to check for this in the lint job, also checking that makemigrations is empty, i.e. all changes have a migration.

@mxsasha mxsasha added this to the v1.9 milestone Mar 7, 2024
@bwbroersma
Copy link
Collaborator

What is the 'migration conflict'? I had the same in the CI runs of #1319 (which I canceled).

@mxsasha
Copy link
Collaborator Author

mxsasha commented Mar 11, 2024

What is the 'migration conflict'? I had the same in the CI runs of #1319 (which I canceled).

The most common form: multiple paths. Your new migration depends on 0015_auto_20240212_1616, but 0015_add_rpki_scoring does too. This means Django can't determine the correct order. I should probably have renamed that to 0016_add_rpki_scoring to avoid Django mis-guessing which one to base a new migration on. The fix for you is to depend on 0015_add_rpki_scoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants