Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIWebView : [Admob] (Deprecated Api Usage) #2943

Closed
1 of 9 tasks
yannou788 opened this issue Nov 28, 2019 · 8 comments
Closed
1 of 9 tasks

UIWebView : [Admob] (Deprecated Api Usage) #2943

yannou788 opened this issue Nov 28, 2019 · 8 comments
Labels
blocked: firebase-sdk Pending a confirmed fix landing on the official native sdk's (iOS/Android). platform: ios plugin: admob Google AdMob Type: Stale Issue has become stale - automatically added by Stale bot

Comments

@yannou788
Copy link

yannou788 commented Nov 28, 2019

Issue

"@react-native-firebase/admob": "6.1.0",
TMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView.

After some research, I found that in RNFBAdMob.podspec there was an dependency with PersonalizedAdConsent (https://github.com/googleads/googleads-consent-sdk-ios/tree/master/PersonalizedAdConsent/PersonalizedAdConsent) which contains call to "UIWebView".


Project Files

iOS

Click To Expand

ios/Podfile:

  • I'm not using Pods
  • I'm using Pods and my Podfile looks like:
# N/A

AppDelegate.m:

// N/A


Android

Click To Expand

Have you converted to AndroidX?

  • my application is an AndroidX application?
  • I am using android/gradle.settings jetifier=true for Android compatibility?
  • I am using the NPM package jetifier for react-native compatibility?

android/build.gradle:

// N/A

android/app/build.gradle:

// N/A

android/settings.gradle:

// N/A

MainApplication.java:

// N/A

AndroidManifest.xml:

<!-- N/A -->


Environment

Click To Expand

react-native info output:

 OUTPUT GOES HERE
  • Platform that you're experiencing the issue on:
    • [x ] iOS
    • Android
    • iOS but have not tested behavior on Android
    • Android but have not tested behavior on iOS
    • Both
  • react-native-firebase version you're using that has this issue:
    • 6.1.0
  • Firebase module(s) you're using that has the issue:
    • Admob
  • Are you using TypeScript?
    • N


Think react-native-firebase is great? Please consider supporting all of the project maintainers and contributors by donating via our Open Collective where all contributors can submit expenses. [Learn More]

@mikehardy
Copy link
Collaborator

That's a google upstream bug. For v6 we need to change the issue template here as I need to see the contents of firebase.json to see if you are using the right versions - but I think this is unresolved anyway: googleads/googleads-consent-sdk-ios#41 - follow along there and be prepared to do something like this when/if it is updated: https://github.com/mikehardy/rnfbdemo/blob/65a23cb22b4b91614746c1997f1bf83ca318016a/make-demo-v6.sh#L30

@stale
Copy link

stale bot commented Dec 26, 2019

Hello 👋, to help manage issues we automatically close stale issues.
This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require the community's attention?

This issue will be closed in 15 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the Type: Stale Issue has become stale - automatically added by Stale bot label Dec 26, 2019
@stale
Copy link

stale bot commented Jan 10, 2020

Closing this issue after a prolonged period of inactivity. If this is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Jan 10, 2020
@oidoug
Copy link

oidoug commented Jan 14, 2020

Will this be retrofitted into v5? I'm not ready to jump to 6 yet and I'm having this issue.

Thanks!

@mikehardy
Copy link
Collaborator

RNFBv5 has no deprecated API usage if you use the up to date firebase SDKs, which you can safely use because I have already retrofitted all the necessary bits

I release to the Apple app store regularly with RNFBv5 + firebase iOS SDKs 6.14.0 (current) and itś fine.

@oidoug
Copy link

oidoug commented Jan 14, 2020

Oh my bad, I thought I was on the latest version.
Thanks Mike!

@rarira
Copy link

rarira commented Jan 17, 2020

if you use v6 and pod, please try to patch..
I successfully released app to app store.
googleads/googleads-consent-sdk-ios#41 (comment)

@mikehardy
Copy link
Collaborator

Oh no - I did not realize there was another usage of UIWebView, thanks for that link @rarira - hopefully it is fixed upstream soon, in the meantime that comment has a great solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: firebase-sdk Pending a confirmed fix landing on the official native sdk's (iOS/Android). platform: ios plugin: admob Google AdMob Type: Stale Issue has become stale - automatically added by Stale bot
Projects
None yet
Development

No branches or pull requests

4 participants