Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration: cleanup Gateway.HTTPHeaders #10005

Closed
Tracked by #174
lidel opened this issue Jun 30, 2023 · 1 comment
Closed
Tracked by #174

migration: cleanup Gateway.HTTPHeaders #10005

lidel opened this issue Jun 30, 2023 · 1 comment
Assignees
@lidel
Labels
effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo P3 Low: Not priority right now topic/config Topic config topic/CORS Issues related to CORS on HTTP endpoints topic/gateway Topic gateway

Comments

@lidel
Copy link
Member

lidel commented Jun 30, 2023 •
edited
Loading

This is a low priority, but the next time we have to write migration for something in Kubo, we should also include the cleanup described in #9994 (comment)

Gateway.HTTPHeaders is now empty on ipfs init and boxo/gateway takes care of setting default CORS headers if user config has none. We will write this down in ipfs/specs#423.

Migration should detect when users had headers set that match the last value from the linked PR, and remove them.
@lidel lidel added topic/gateway Topic gateway P3 Low: Not priority right now topic/config Topic config kind/maintenance Work required to avoid breaking changes or harm to project's status quo effort/hours Estimated to take one or several hours topic/CORS Issues related to CORS on HTTP endpoints labels Jun 30, 2023
@lidel lidel moved this to 🥞 Todo in IPFS Shipyard Team Jun 30, 2023
@lidel lidel self-assigned this Jul 6, 2023
@lidel
Copy link
Member Author

lidel commented Jul 27, 2023 •
edited
Loading

Sidenote: if we write this migration, we should also consider including /quic cleanup described in #9496 (comment)

@BigLep BigLep mentioned this issue Aug 3, 2023
Closed
@lidel lidel mentioned this issue Aug 28, 2023
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from 🥞 Todo to 🎉 Done in IPFS Shipyard Team Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo P3 Low: Not priority right now topic/config Topic config topic/CORS Issues related to CORS on HTTP endpoints topic/gateway Topic gateway
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel