From b4aa7365861c3fc172d2ce8f9c029829137c5712 Mon Sep 17 00:00:00 2001 From: its-a-feature Date: Wed, 27 Nov 2024 16:07:07 -0600 Subject: [PATCH] updating the _use_volume setting to false for new agent installs --- Mythic_CLI/Changelog.md | 7 +++++++ Mythic_CLI/src/cmd/config/vars.go | 2 +- Mythic_CLI/src/cmd/internal/installservice.go | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Mythic_CLI/Changelog.md b/Mythic_CLI/Changelog.md index c5a800df..e41ac389 100644 --- a/Mythic_CLI/Changelog.md +++ b/Mythic_CLI/Changelog.md @@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). +## 0.3.7 - + +### Changed + +- Updated the default value for an installed service's *_use_volume setting to be `false` instead of `true` + - too many people were having issues with lingering volumes, so it's better to have people explicitly set this if they need it + ## 0.3.6 - 2024-11-25 ### Changed diff --git a/Mythic_CLI/src/cmd/config/vars.go b/Mythic_CLI/src/cmd/config/vars.go index 294fd34a..5b157493 100644 --- a/Mythic_CLI/src/cmd/config/vars.go +++ b/Mythic_CLI/src/cmd/config/vars.go @@ -4,5 +4,5 @@ package config var ( // Version Mythic CLI version - Version = "v0.3.6" + Version = "v0.3.7" ) diff --git a/Mythic_CLI/src/cmd/internal/installservice.go b/Mythic_CLI/src/cmd/internal/installservice.go index 975b4b6a..2192ec35 100644 --- a/Mythic_CLI/src/cmd/internal/installservice.go +++ b/Mythic_CLI/src/cmd/internal/installservice.go @@ -41,7 +41,7 @@ func InstallFolder(installPath string, overWrite bool, keepVolume bool, installU for key, val := range latestVersion { config.SetNewConfigStrings(fmt.Sprintf("%s_remote_image", key), val) if !config.GetMythicEnv().InConfig(fmt.Sprintf("%s_use_volume", key)) { - config.SetNewConfigStrings(fmt.Sprintf("%s_use_volume", key), "true") + config.SetNewConfigStrings(fmt.Sprintf("%s_use_volume", key), "false") } if !config.GetMythicEnv().InConfig(fmt.Sprintf("%s_use_build_context", key)) { config.SetNewConfigStrings(fmt.Sprintf("%s_use_build_context", key), "false")