Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish oweno-tfwm merge #71

Open
mem48 opened this issue Oct 10, 2024 · 2 comments
Open

Finish oweno-tfwm merge #71

mem48 opened this issue Oct 10, 2024 · 2 comments

Comments

@mem48
Copy link
Contributor

mem48 commented Oct 10, 2024

Merge conflics and oustadning bugs nearly completed on @oweno-tfwm 's massive PR last few things to fix are

Warning message:
── Conflicts ─────────────────────────────────────────────────────────────────────────────────────────────────────────────── UK2GTFS conflicts
──
✖ `load_data` masks `UK2GTFS::load_data()`.
✖ `update_data` masks `UK2GTFS::update_data()`.
ℹ Did you accidentally source a file rather than using `load_all()`?
  Run `rm(list = c("load_data", "update_data"))` to remove the conflicts. 
> devtools::check()
══ Documenting ══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
ℹ Updating UK2GTFS documentation
ℹ Loading UK2GTFS
Your UK2GTFS data is up to date

══ Building ═════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Setting env vars:
• CFLAGS    : -Wall -pedantic -fdiagnostics-color=always
• CXXFLAGS  : -Wall -pedantic -fdiagnostics-color=always
• CXX11FLAGS: -Wall -pedantic -fdiagnostics-color=always
• CXX14FLAGS: -Wall -pedantic -fdiagnostics-color=always
• CXX17FLAGS: -Wall -pedantic -fdiagnostics-color=always
• CXX20FLAGS: -Wall -pedantic -fdiagnostics-color=always
── R CMD build ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
✔  checking for file 'C:\Users\malco\Documents\GitHub\dabreegster\UK2GTFS/DESCRIPTION' ...
─  preparing 'UK2GTFS': (1.7s)
✔  checking DESCRIPTION meta-information ... 
─  installing the package to build vignettes
✔  creating vignettes (21.6s)
─  checking for LF line-endings in source and make files and shell scripts (693ms)
─  checking for empty or unneeded directories
─  building 'UK2GTFS_0.3.0.tar.gz'
   
══ Checking ═════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Setting env vars:
• _R_CHECK_CRAN_INCOMING_REMOTE_               : FALSE
• _R_CHECK_CRAN_INCOMING_                      : FALSE
• _R_CHECK_FORCE_SUGGESTS_                     : FALSE
• _R_CHECK_PACKAGES_USED_IGNORE_UNUSED_IMPORTS_: FALSE
• NOT_CRAN                                     : true
── R CMD check ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
─  using log directory 'C:/Users/malco/AppData/Local/Temp/RtmpOwAVTD/file2b9c50d6106a/UK2GTFS.Rcheck'
─  using R version 4.2.1 (2022-06-23 ucrt)
─  using platform: x86_64-w64-mingw32 (64-bit)
─  using session charset: UTF-8
─  using options '--no-manual --as-cran' (1.9s)
✔  checking for file 'UK2GTFS/DESCRIPTION'
─  checking extension type ... Package
─  this is package 'UK2GTFS' version '0.3.0'
─  package encoding: UTF-8
✔  checking package namespace information ... 
N  checking package dependencies (3.1s)
   Imports includes 22 non-default packages.
   Importing from so many packages makes the package vulnerable to any of
   them becoming unavailable.  Move as many as possible to Suggests and
   use conditionally.
✔  checking if this is a source package ... 
✔  checking if there is a namespace
✔  checking for executable files (1.4s)
✔  checking for hidden files and directories ... 
✔  checking for portable file names ... 
✔  checking whether package 'UK2GTFS' can be installed (20.2s)
N  checking installed package size ... 
     installed size is 45.3Mb
     sub-directories of 1Mb or more:
       extdata  44.6Mb
✔  checking package directory (420ms)
✔  checking for future file timestamps ... 
✔  checking 'build' directory ...
✔  checking DESCRIPTION meta-information (381ms)
✔  checking top-level files
✔  checking for left-over files ... 
✔  checking index information (336ms)
✔  checking package subdirectories (369ms)
✔  checking R files for non-ASCII characters ... 
✔  checking R files for syntax errors ... 
✔  checking whether the package can be loaded (5.9s)
✔  checking whether the package can be loaded with stated dependencies (5.8s)
✔  checking whether the package can be unloaded cleanly (5.9s)
✔  checking whether the namespace can be loaded with stated dependencies (5.7s)
✔  checking whether the namespace can be unloaded cleanly (5.9s)
✔  checking loading without being on the library search path (6s)
W  checking dependencies in R code (7.3s)
   '::' or ':::' import not declared from: 'pbapply'
✔  checking S3 generic/method consistency (6.4s)
✔  checking replacement functions (5.8s)
✔  checking foreign function calls (6.2s)
N  checking R code for possible problems (36.3s)
   Found the following possibly unsafe calls:
   File 'UK2GTFS/R/atoc_overlay.R':
     unlockBinding(name, env)
   
   duplicate_related_items: no visible global function definition for
     'setNames'
   gtfs_stop_frequency: no visible binding for global variable
     'runs_total'
   gtfs_trips_per_zone: no visible binding for global variable 'weekday'
   internal_trips_per_zone: no visible binding for global variable
     'band_hours'
   internal_trips_per_zone: no visible binding for global variable
     'routes'
   Undefined global functions or variables:
     band_hours routes runs_total setNames weekday
   Consider adding
     importFrom("stats", "setNames")
   to your NAMESPACE file.
✔  checking Rd files (556ms)
✔  checking Rd metadata ... 
✔  checking Rd line widths ... 
✔  checking Rd cross-references (347ms)
✔  checking for missing documentation entries (5.8s)
✔  checking for code/documentation mismatches (17.6s)
W  checking Rd \usage sections (454ms)
   Undocumented arguments in documentation object 'get_naptan_xml_doc'
     'method'
   
   Functions with \usage entries need to have the appropriate \alias
   entries, and all their arguments documented.
   The \usage entries must correspond to syntactically valid R code.
   See chapter 'Writing R documentation files' in the 'Writing R
   Extensions' manual.
✔  checking Rd contents (6.6s)
✔  checking for unstated dependencies in examples ... 
✔  checking contents of 'data' directory ... 
✔  checking data for non-ASCII characters ... 
✔  checking LazyData
✔  checking data for ASCII and uncompressed saves ... 
✔  checking installed files from 'inst/doc' ... 
✔  checking files in 'vignettes' ... 
─  checking examples ... NONE
✔  checking for unstated dependencies in 'tests' ... 
─  checking tests ...
─  Running 'testthat.R' [74s] (1m 13.7s)
E  Some test files failed
   Running the tests in 'tests/testthat.R' failed.
   Last 13 lines of output:
     ── Failure ('test_transxchange.R:83:3'): Can compress GTFS ─────────────────────
     as.numeric(object.size(gtfs5)) < as.numeric(object.size(gtfs)) is not TRUE
     
     `actual`:   FALSE
     `expected`: TRUE 
     ── Error ('test_transxchange.R:88:3'): Can split GTFS ──────────────────────────
     Error in `UseMethod("left_join")`: no applicable method for 'left_join' applied to an object of class "NULL"
     Backtrace:
         ▆
      1. └─UK2GTFS::gtfs_split(gtfs) at test_transxchange.R:88:2
      2.   └─dplyr::left_join(...)
     
     [ FAIL 8 | WARN 12 | SKIP 0 | PASS 46 ]
     Error: Test failures
     Execution halted
✔  checking for unstated dependencies in vignettes (346ms)
✔  checking package vignettes in 'inst/doc' ... 
✔  checking re-building of vignette outputs (2.4s)
✔  checking for non-standard things in the check directory
✔  checking for detritus in the temp directory ...
   
   See
     'C:/Users/malco/AppData/Local/Temp/RtmpOwAVTD/file2b9c50d6106a/UK2GTFS.Rcheck/00check.log'
   for details.
   
   
── R CMD check results ─────────────────────────────────────────────────────────────────────────────────────────────────────── UK2GTFS 0.3.0 ────
Duration: 3m 58.8s

❯ checking tests ...
  See below...

❯ checking dependencies in R code ... WARNING
  '::' or ':::' import not declared from: 'pbapply'

❯ checking Rd \usage sections ... WARNING
  Undocumented arguments in documentation object 'get_naptan_xml_doc'
    'method'
  
  Functions with \usage entries need to have the appropriate \alias
  entries, and all their arguments documented.
  The \usage entries must correspond to syntactically valid R code.
  See chapter 'Writing R documentation files' in the 'Writing R
  Extensions' manual.

❯ checking package dependencies ... NOTE
  Imports includes 22 non-default packages.
  Importing from so many packages makes the package vulnerable to any of
  them becoming unavailable.  Move as many as possible to Suggests and
  use conditionally.

❯ checking installed package size ... NOTE
    installed size is 45.3Mb
    sub-directories of 1Mb or more:
      extdata  44.6Mb

❯ checking R code for possible problems ... NOTE
  Found the following possibly unsafe calls:
  File 'UK2GTFS/R/atoc_overlay.R':
    unlockBinding(name, env)
  
  duplicate_related_items: no visible global function definition for
    'setNames'
  gtfs_stop_frequency: no visible binding for global variable
    'runs_total'
  gtfs_trips_per_zone: no visible binding for global variable 'weekday'
  internal_trips_per_zone: no visible binding for global variable
    'band_hours'
  internal_trips_per_zone: no visible binding for global variable
    'routes'
  Undefined global functions or variables:
    band_hours routes runs_total setNames weekday
  Consider adding
    importFrom("stats", "setNames")
  to your NAMESPACE file.

── Test failures ────────────────────────────────────────────────────────────────────────────────────────────────────────────────── testthat ────

> library(testthat)
Warning message:
package 'testthat' was built under R version 4.2.3 
> library(UK2GTFS)
Your UK2GTFS data is up to date
> 
> test_check("UK2GTFS")
Error in dplyr::bind_rows(matched, .id = "file_id") : 
  Can't combine `1$exception_type` <double> and `9$exception_type` <character>.
[ FAIL 8 | WARN 12 | SKIP 0 | PASS 46 ]

══ Warnings ════════════════════════════════════════════════════════════════════
── Warning ('test_atoc.R:16:3'): test atoc2gtfs singlecore ─────────────────────
2024-10-10 14:37:05 Some calendar dates had incorrect start or end dates that did not align with operating day bitmask.
 Services=Y57169
Backtrace:
    ▆
 1. └─UK2GTFS::atoc2gtfs(...) at test_atoc.R:16:2
 2.   └─UK2GTFS:::schedule2routes(...)
 3.     └─UK2GTFS:::makeCalendar(schedule = schedule, ncores = ncores)
 4.       └─base::tryCatch(...)
 5.         └─base (local) tryCatchList(expr, classes, parentenv, handlers)
── Warning ('test_atoc.R:26:3'): test atoc2gtfs singlecore ─────────────────────
2024-10-10 14:37:09 Some calendar dates had incorrect start or end dates that did not align with operating day bitmask.
 Services=Y57169
Backtrace:
    ▆
 1. └─UK2GTFS::atoc2gtfs(...) at test_atoc.R:26:2
 2.   └─UK2GTFS:::schedule2routes(...)
 3.     └─UK2GTFS:::makeCalendar(schedule = schedule, ncores = ncores)
 4.       └─base::tryCatch(...)
 5.         └─base (local) tryCatchList(expr, classes, parentenv, handlers)
── Warning ('test_transxchange.R:6:1'): (code run outside of `test_that()`) ────
'C:\Users\malco\AppData\Local\Temp\Rtmp6vd3Xs\working_dir\Rtmp4kiCSM\uk2gtfs_data' already exists
Backtrace:
    ▆
 1. └─base::dir.create(data_path) at test_transxchange.R:6:0
── Warning ('test_transxchange.R:24:3'): test transxchange2gtfs singlecore ─────
Detected an unexpected many-to-many relationship between `x` and `y`.
ℹ Row 1 of `x` matches multiple rows in `y`.
ℹ Row 1 of `y` matches multiple rows in `x`.
ℹ If a many-to-many relationship is expected, set `relationship =
  "many-to-many"` to silence this warning.
Backtrace:
     ▆
  1. ├─UK2GTFS::transxchange2gtfs(...) at test_transxchange.R:24:2
  2. │ └─purrr::map(...)
  3. │   └─purrr:::map_("list", .x, .f, ..., .progress = .progress)
  4. │     ├─purrr:::with_indexed_errors(...)
  5. │     │ └─base::withCallingHandlers(...)
  6. │     ├─purrr:::call_with_cleanup(...)
  7. │     └─UK2GTFS (local) .f(.x[[i]], ...)
  8. │       └─UK2GTFS:::transxchange_export(...)
  9. │         ├─dplyr::left_join(...)
 10. │         └─dplyr:::left_join.data.frame(...)
 11. │           └─dplyr:::join_mutate(...)
 12. │             └─dplyr:::join_rows(...)
 13. │               └─dplyr:::dplyr_locate_matches(...)
 14. │                 ├─base::withCallingHandlers(...)
 15. │                 └─vctrs::vec_locate_matches(...)
 16. ├─vctrs:::warn_matches_relationship_many_to_many(...)
 17. │ └─vctrs:::warn_matches_relationship(...)
 18. │   └─vctrs:::warn_matches(...)
 19. │     └─vctrs:::warn_vctrs(...)
 20. │       └─rlang::warn(...)
 21. │         └─base::warning(cnd)
 22. │           └─base::withRestarts(...)
 23. │             └─base (local) withOneRestart(expr, restarts[[1L]])
 24. │               └─base (local) doWithOneRestart(return(expr), restart)
 25. └─dplyr (local) `<fn>`(`<vc______>`)
 26.   └─dplyr:::rethrow_warning_join_relationship_many_to_many(cnd, error_call)
 27.     └─dplyr:::warn_join(...)
 28.       └─dplyr:::warn_dplyr(...)
── Warning ('test_transxchange.R:24:3'): test transxchange2gtfs singlecore ─────
Detected an unexpected many-to-many relationship between `x` and `y`.
ℹ Row 1 of `x` matches multiple rows in `y`.
ℹ Row 1 of `y` matches multiple rows in `x`.
ℹ If a many-to-many relationship is expected, set `relationship =
  "many-to-many"` to silence this warning.
Backtrace:
     ▆
  1. ├─UK2GTFS::transxchange2gtfs(...) at test_transxchange.R:24:2
  2. │ └─purrr::map(...)
  3. │   └─purrr:::map_("list", .x, .f, ..., .progress = .progress)
  4. │     ├─purrr:::with_indexed_errors(...)
  5. │     │ └─base::withCallingHandlers(...)
  6. │     ├─purrr:::call_with_cleanup(...)
  7. │     └─UK2GTFS (local) .f(.x[[i]], ...)
  8. │       └─UK2GTFS:::transxchange_export(...)
  9. │         ├─dplyr::left_join(...)
 10. │         └─dplyr:::left_join.data.frame(...)
 11. │           └─dplyr:::join_mutate(...)
 12. │             └─dplyr:::join_rows(...)
 13. │               └─dplyr:::dplyr_locate_matches(...)
 14. │                 ├─base::withCallingHandlers(...)
 15. │                 └─vctrs::vec_locate_matches(...)
 16. ├─vctrs:::warn_matches_relationship_many_to_many(...)
 17. │ └─vctrs:::warn_matches_relationship(...)
 18. │   └─vctrs:::warn_matches(...)
 19. │     └─vctrs:::warn_vctrs(...)
 20. │       └─rlang::warn(...)
 21. │         └─base::warning(cnd)
 22. │           └─base::withRestarts(...)
 23. │             └─base (local) withOneRestart(expr, restarts[[1L]])
 24. │               └─base (local) doWithOneRestart(return(expr), restart)
 25. └─dplyr (local) `<fn>`(`<vc______>`)
 26.   └─dplyr:::rethrow_warning_join_relationship_many_to_many(cnd, error_call)
 27.     └─dplyr:::warn_join(...)
 28.       └─dplyr:::warn_dplyr(...)
── Warning ('test_transxchange.R:24:3'): test transxchange2gtfs singlecore ─────
Detected an unexpected many-to-many relationship between `x` and `y`.
ℹ Row 1 of `x` matches multiple rows in `y`.
ℹ Row 1 of `y` matches multiple rows in `x`.
ℹ If a many-to-many relationship is expected, set `relationship =
  "many-to-many"` to silence this warning.
Backtrace:
     ▆
  1. ├─UK2GTFS::transxchange2gtfs(...) at test_transxchange.R:24:2
  2. │ └─purrr::map(...)
  3. │   └─purrr:::map_("list", .x, .f, ..., .progress = .progress)
  4. │     ├─purrr:::with_indexed_errors(...)
  5. │     │ └─base::withCallingHandlers(...)
  6. │     ├─purrr:::call_with_cleanup(...)
  7. │     └─UK2GTFS (local) .f(.x[[i]], ...)
  8. │       └─UK2GTFS:::transxchange_export(...)
  9. │         ├─dplyr::left_join(...)
 10. │         └─dplyr:::left_join.data.frame(...)
 11. │           └─dplyr:::join_mutate(...)
 12. │             └─dplyr:::join_rows(...)
 13. │               └─dplyr:::dplyr_locate_matches(...)
 14. │                 ├─base::withCallingHandlers(...)
 15. │                 └─vctrs::vec_locate_matches(...)
 16. ├─vctrs:::warn_matches_relationship_many_to_many(...)
 17. │ └─vctrs:::warn_matches_relationship(...)
 18. │   └─vctrs:::warn_matches(...)
 19. │     └─vctrs:::warn_vctrs(...)
 20. │       └─rlang::warn(...)
 21. │         └─base::warning(cnd)
 22. │           └─base::withRestarts(...)
 23. │             └─base (local) withOneRestart(expr, restarts[[1L]])
 24. │               └─base (local) doWithOneRestart(return(expr), restart)
 25. └─dplyr (local) `<fn>`(`<vc______>`)
 26.   └─dplyr:::rethrow_warning_join_relationship_many_to_many(cnd, error_call)
 27.     └─dplyr:::warn_join(...)
 28.       └─dplyr:::warn_dplyr(...)
── Warning ('test_transxchange.R:53:1'): (code run outside of `test_that()`) ───
error 1 in extracting from zip file
Backtrace:
    ▆
 1. └─UK2GTFS::gtfs_read(file.path(file_path, "txc_gtfs2.zip")) at test_transxchange.R:53:0
 2.   └─utils::unzip(path, exdir = tmp_folder)
── Warning ('test_transxchange.R:53:1'): (code run outside of `test_that()`) ───
Unable to find required file: agency.txt
Backtrace:
    ▆
 1. └─UK2GTFS::gtfs_read(file.path(file_path, "txc_gtfs2.zip")) at test_transxchange.R:53:0
── Warning ('test_transxchange.R:53:1'): (code run outside of `test_that()`) ───
Unable to find required file: stops.txt
Backtrace:
    ▆
 1. └─UK2GTFS::gtfs_read(file.path(file_path, "txc_gtfs2.zip")) at test_transxchange.R:53:0
── Warning ('test_transxchange.R:53:1'): (code run outside of `test_that()`) ───
Unable to find required file: routes.txt
Backtrace:
    ▆
 1. └─UK2GTFS::gtfs_read(file.path(file_path, "txc_gtfs2.zip")) at test_transxchange.R:53:0
── Warning ('test_transxchange.R:53:1'): (code run outside of `test_that()`) ───
Unable to find required file: trips.txt
Backtrace:
    ▆
 1. └─UK2GTFS::gtfs_read(file.path(file_path, "txc_gtfs2.zip")) at test_transxchange.R:53:0
── Warning ('test_transxchange.R:53:1'): (code run outside of `test_that()`) ───
Unable to find required file: stop_times.txt
Backtrace:
    ▆
 1. └─UK2GTFS::gtfs_read(file.path(file_path, "txc_gtfs2.zip")) at test_transxchange.R:53:0

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test_aa_unit.R:459:3'): test duplicate_stop_times:1 ─────────────────
<packageNotFoundError/error/condition>
Error in `loadNamespace(x)`: there is no package called 'pbapply'
Backtrace:
    ▆
 1. ├─UK2GTFS:::duplicate_stop_times(testCalendar, testStopTimes, ncores = 1) at test_aa_unit.R:459:2
 2. │ └─UK2GTFS:::duplicate_related_items(...)
 3. │   └─UK2GTFS:::duplicateItems(...)
 4. └─base::loadNamespace(x)
 5.   └─base::withRestarts(stop(cond), retry_loadNamespace = function() NULL)
 6.     └─base (local) withOneRestart(expr, restarts[[1L]])
 7.       └─base (local) doWithOneRestart(return(expr), restart)
── Error ('test_aa_unit.R:728:3'): test duplicateItems:1 ───────────────────────
Error in `.check_ncores(length(names))`: 4 simultaneous processes spawned
Backtrace:
    ▆
 1. └─UK2GTFS:::duplicateItems(testData, "UID", ncores = 4) at test_aa_unit.R:728:2
 2.   └─parallel::makeCluster(ncores)
 3.     └─parallel::makePSOCKcluster(names = spec, ...)
 4.       └─parallel:::.check_ncores(length(names))
── Error ('test_atoc.R:16:3'): test atoc2gtfs singlecore ───────────────────────
<packageNotFoundError/error/condition>
Error in `loadNamespace(x)`: there is no package called 'pbapply'
Backtrace:
    ▆
 1. ├─UK2GTFS::atoc2gtfs(...) at test_atoc.R:16:2
 2. │ └─UK2GTFS:::schedule2routes(...)
 3. │   └─UK2GTFS:::makeCalendar(schedule = schedule, ncores = ncores)
 4. │     └─base::tryCatch(...)
 5. │       └─base (local) tryCatchList(expr, classes, parentenv, handlers)
 6. └─base::loadNamespace(x)
 7.   └─base::withRestarts(stop(cond), retry_loadNamespace = function() NULL)
 8.     └─base (local) withOneRestart(expr, restarts[[1L]])
 9.       └─base (local) doWithOneRestart(return(expr), restart)
── Error ('test_atoc.R:26:3'): test atoc2gtfs singlecore ───────────────────────
<packageNotFoundError/error/condition>
Error in `loadNamespace(x)`: there is no package called 'pbapply'
Backtrace:
    ▆
 1. ├─UK2GTFS::atoc2gtfs(...) at test_atoc.R:26:2
 2. │ └─UK2GTFS:::schedule2routes(...)
 3. │   └─UK2GTFS:::makeCalendar(schedule = schedule, ncores = ncores)
 4. │     └─base::tryCatch(...)
 5. │       └─base (local) tryCatchList(expr, classes, parentenv, handlers)
 6. └─base::loadNamespace(x)
 7.   └─base::withRestarts(stop(cond), retry_loadNamespace = function() NULL)
 8.     └─base (local) withOneRestart(expr, restarts[[1L]])
 9.       └─base (local) doWithOneRestart(return(expr), restart)
── Error ('test_transxchange.R:60:3'): Can clean GTFS ──────────────────────────
Error in `"trip_id" %in% stop_count[N < 2]$trip_id`: object 'N' not found
Backtrace:
    ▆
 1. └─UK2GTFS::gtfs_clean(gtfs) at test_transxchange.R:60:2
 2.   └─"trip_id" %in% stop_count[N < 2]$trip_id
── Error ('test_transxchange.R:75:3'): Can subset GTFS ─────────────────────────
Error in `UseMethod("st_as_sf")`: no applicable method for 'st_as_sf' applied to an object of class "list"
Backtrace:
    ▆
 1. └─UK2GTFS::gtfs_clip(gtfs, bounds) at test_transxchange.R:75:2
 2.   └─sf::st_as_sf(stops_inc, coords = c("stop_lon", "stop_lat"), crs = 4326)
── Failure ('test_transxchange.R:83:3'): Can compress GTFS ─────────────────────
as.numeric(object.size(gtfs5)) < as.numeric(object.size(gtfs)) is not TRUE

`actual`:   FALSE
`expected`: TRUE 
── Error ('test_transxchange.R:88:3'): Can split GTFS ──────────────────────────
Error in `UseMethod("left_join")`: no applicable method for 'left_join' applied to an object of class "NULL"
Backtrace:
    ▆
 1. └─UK2GTFS::gtfs_split(gtfs) at test_transxchange.R:88:2
 2.   └─dplyr::left_join(...)

[ FAIL 8 | WARN 12 | SKIP 0 | PASS 46 ]
Error: Test failures
Execution halted

1 error ✖ | 2 warnings ✖ | 3 notes ✖
@oweno-tfwm
Copy link
Contributor

oweno-tfwm commented Oct 10, 2024 via email

@mem48
Copy link
Contributor Author

mem48 commented Nov 30, 2024

Still outstaing issues

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test_atoc.R:16:3'): test atoc2gtfs singlecore ───────────────────────
Error in `rbindlist(l, use.names, fill, idcol)`: Item 2 has 5 columns, inconsistent with item 1 which has 6 columns. To fill missing columns use fill=TRUE.
Backtrace:
    ▆
 1. └─UK2GTFS::atoc2gtfs(...) at test_atoc.R:16:2
 2.   └─base::rbind(stops_sf, stops_missing)
 3.     └─data.table (local) rbind(deparse.level, ...)
 4.       └─data.table::rbindlist(l, use.names, fill, idcol)
── Error ('test_transxchange.R:31:3'): test transxchange2gtfs singlecore ───────
Error in `if (!is.null(table) & nrow(table) > 0) {
    data.table::fwrite(table, file.path(tempdir(), "gtfs_temp", 
        paste0(tableName, ".txt")), row.names = FALSE, quote = quote)
}`: argument is of length zero
Backtrace:
    ▆
 1. └─UK2GTFS::gtfs_write(gtfs, folder = file_path, name = "txc_gtfs2") at test_transxchange.R:31:2
── Error ('test_transxchange.R:53:1'): (code run outside of `test_that()`) ─────
Error in `gtfs_read(file.path(file_path, "txc_gtfs2.zip"))`: Assertion on 'path' failed: File does not exist: 'C:\Users\malco\AppData\Local\Temp\RtmpW8wjC7/working_dir\RtmpolPGl2/uk2gtfs_tests/txc_gtfs2.zip'.
Backtrace:
    ▆
 1. └─UK2GTFS::gtfs_read(file.path(file_path, "txc_gtfs2.zip")) at test_transxchange.R:53:0
 2.   └─checkmate::assert_file_exists(path)
 3.     └─checkmate::makeAssertion(x, res, .var.name, add)
 4.       └─checkmate:::mstop(...)

[ FAIL 3 | WARN 5 | SKIP 0 | PASS 46 ]
Error: Test failures
Execution halted

1 error ✖ | 0 warnings ✔ | 3 notes ✖
Error: R CMD check found ERRORs
Execution halted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mem48 @oweno-tfwm