Where is qApp defined?

[eyllanesc]

In the following lines of source code:

qtgallery/qtgallery/qtscraper.py

Lines 52 to 53 in 17fdd1c

	if qApp:
	qApp.shutdown()

I see that the qApp variable is used but it has not been created or imported.

[ixjlyons]

Great question - I had completely forgotten and my first thought was it was an oversight from a refactor or something.

qApp is available as a side-effect of importing QApplication when pyside2 or pyside6 is being used. After a little testing, it doesn't seem necessary to use qApp to call shutdown and QApplication.instance().shutdown() seems to work, so this would probably be better:

from qtpy import QT_API
# ...
if QT_API in {"pyside2", "pyside6"}:
    QApplication.instance().shutdown()

I don't recall why shutdown() was necessary here, but presumably I found it prevented the docs build from hanging with pyside.

[eyllanesc]

@ixjlyons Can you enable Github Discussions and move this issue there?

I am implementing a PR to support not only QtWidgets but also other windows like QML.

[ixjlyons]

Done. Happy to have help generalizing this and making it more robust.