Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to parcel v2, react 18 for example folder #1178

Open
haotang-dayone opened this issue Apr 21, 2023 · 1 comment
Open

Upgrade to parcel v2, react 18 for example folder #1178

haotang-dayone opened this issue Apr 21, 2023 · 1 comment

Comments

@haotang-dayone
Copy link

Current Behavior

Example dir: Use parcel 1, react 16
src and package.json: use react 18
=> sometimes example can't run or has incompatibility issue

Desired Behavior

Both use react 18
Example dir uses parcel v2

Suggested Solution

Update example to

  • use parcel 2
  • update @types to use react 18 types
  • use react createRoot: tps://reactjs.org/link/switch-to-createroot
  • fix any consequential issues happening
@kashaudhan
Copy link

refer pr #1183 for resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants