file name mess when open nnn

[beautiful-boyyy]

font: JetBrainsMono Nerd Font Mono
Desktop, Download... first letter double, I tried other nerd font, still have this problem

[jarun]

Program version, locale, terminal emulator? I also use the same font without any issues.

[beautiful-boyyy]

Do you see the problem with icons disabled? Also, how about nnn v4.7?

icons disabled and v4.7 is ok, maybe v4.8 broke something

[jarun]

Nerd Fonts changed something. Maybe a side effect. Can you try emoji?

@N-R-K or @luukvbaal?

[N-R-K]

Make sure you're using nnn from master and nerd font v3 or above.

[luukvbaal]

No idea sorry, I doubt this is a font problem though.

[cyaconi]

Did you solve this problem? I'm experiencing same issue with O_NERD=1 and font-jetbrains-mono-nerd-font v3.0.1

[FabioAntunes]

I'm experiencing the same issue, on certain icons but only when I highlight it and then disregard it. The highlighted row is fine, but as soon as I move out of it it gets an extra letter.

Some pics to explain it:

Move to the next item:

More examples:

In this example by just moving to the next one both get an extra character

[N-R-K]

If you can compile nnn from master with O_DEBUG=1 then run nnn - it will output some debug logs to /tmp/nnndbg. The debug logs might reveal something useful.

[cyaconi]

I compiled with the O_DEBUG=1, then run nnn in the same directory and moved the cursor to replicate the problem (replicated). This is the log file content:

ln 8644: VERSION=4.8
ln 8433: g_tmpfpath=/tmp
ln 8434: tmpfplen=5
ln 8677: home=/Users/carlos
ln 8381: cfgpath=/Users/carlos/.config
ln 8387: cfgpath=/Users/carlos/.config/nnn
ln 8415: selpath=/Users/carlos/.config/nnn/.selection
ln 8685: opener=/usr/bin/open
ln 8795: getenv(envs[ENV_VISUAL])=(null)
ln 8796: getenv(envs[ENV_EDITOR])=nvim
ln 8797: editor=nvim
ln 8801: pager=less
ln 8805: shell=/bin/zsh
ln 8807: getenv("PWD")=/Users/carlos/dev/code/macos/nnn
ln 2223: COLORS=256
ln 2224: COLOR_PAIRS=32767
ln 5690: __func__=dentfill
ln 5957: ts2.tv_nsec - ts1.tv_nsec=98000
ln 6547: __func__=redraw
ln 6562: path=/Users/carlos/dev/code/macos/nnn

Hope it helps 🤞

[N-R-K]

@beautiful-boyyy @FabioAntunes Are you guys also using macos as well? If yes, then it that might be a clue.

[cyaconi]

macOS and Kitty over here

[FabioAntunes]

I’m using macos and iterm

…

On Fri, 14 Jul 2023 at 11:28, NRK ***@***.***> wrote: @beautiful-boyyy <https://github.com/beautiful-boyyy> @FabioAntunes <https://github.com/FabioAntunes> Are you guys also using macos as well? If yes, then it that might be a clue. — Reply to this email directly, view it on GitHub <#1662 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATNIII7ZVIMZ7KW3AUDCF3XQENMDANCNFSM6AAAAAAYTK2OJM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jarun]

Please see #1692 (comment). Someone needs to test and raise a PR.

[quantonganh]

To anyone using macOS: could you please help me test this and let me know the result.

TBH, I'm still trying to find out why increase the ICON_PADDING_RIGHT to >= 7 spaces appears to resolve this issue :D.

[FabioAntunes]

It sort of fixes it, but now there's a massive gap between icons and file names and they aren't aligned.

The fix

The broken:

Also this is using luukvbaal/nnn.nvim not sure if changes anything.
Just tested with nnn in a terminal and the result is exactly the same.

[quantonganh]

and they aren't aligned.

We can fix it by adjusting the padding based on the width of an icon.

but now there's a massive gap between icons and file names

I need to find out the root cause.

[FabioAntunes]

Ok sorry, it seems that starting from 6 is when the left alignment stops and the duplication is fixed.

#if defined(EMOJI) || defined(NERD)
	/*
	 * NOTE: As some emojis take up two cells, all of the emoji icons must
	 * be of width 2. Therefore, right pad single-width emoji with a space.
	 */
	#define ICON_SIZE 2
	#define ICON_PADDING_RIGHT "      "
#else
	#define ICON_SIZE 1
	#define ICON_PADDING_RIGHT "  "
#endif

With 6 spaces

[quantonganh]

The problem with 6 spaces is if you go to misc you will see it still occurs:

and then if you go back:

[FabioAntunes]

You are right, but that's because it's not "breaking" the left alignment.

if I go inside the misc/ folder and come back, the left alignment is not broken anymore:

before going to misc/

misc/

back to root folder

You can see they are aligned again

Then if I hover the icons it will be broken.

[quantonganh]

That non alignment is what makes the solution to work.

Not sure if I understand. Could you please explain? Why the misalignment can solve this issue?

I believe that the misalignment is caused by the width of an icon on macOS:

[FabioAntunes]

This is just an assumption. My guess is that the left alignment is miscalculating the width of icon. When you don’t have left alignment it works. I’m not sure why hovering changes the left alignment

[quantonganh]

@FabioAntunes Do you have some time to test #1711?

[FabioAntunes]

That's almost it!

When I hover I still get duplicated letter,

But if a move to the next one, CHANGELOG goes back to normal

So right now the only thing is broken is the hovering.

[quantonganh]

It's weird. I tested on 2 machines and 4 terminals (WezTerm, iTerm, kitty, Alacritty) and everything works fine:

[FabioAntunes]

This what I'm testing.

And then make O_NERD=1

[quantonganh]

Ah, you need to do the same before calling printent(&pdents[cur], ncols, TRUE);:

---
 src/nnn.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/nnn.c b/src/nnn.c
index 5af2b1b7..23e66e10 100644
--- a/src/nnn.c
+++ b/src/nnn.c
@@ -6520,6 +6520,8 @@ static void draw_line(int ncols)
        }

        move(2 + last - curscroll, 0);
+       clrtoeol();
+       refresh();
        printent(&pdents[last], ncols, FALSE);

        if (g_state.oldcolor && (pdents[cur].flags & DIR_OR_DIRLNK)) {
@@ -6533,6 +6535,8 @@ static void draw_line(int ncols)
        }

        move(2 + cur - curscroll, 0);
+       clrtoeol();
+       refresh();
        printent(&pdents[cur], ncols, TRUE);

        /* Must reset e.g. no files in dir */

[FabioAntunes]

AH! my bad. yep that fixes the issue. Nice one!! 🥇

[N-R-K]

Should be fixed by #1711