Why not pick files by pressing l in picker mode?

[Oxore]

When using NNN inside vim either with mcchrish/nnn.vim or with luukvbaal/nnn.nvim, I'm having a frustrating experience, because I used to open files with l or right arrow. But in a picker mode NNN does not select the file for the vim plugin to open, instead it actually opens it with whatever configured to open files of the type of selected file.

With mcchrish/nnn.vim plugin I've been using the following configuration line for nvim for 9 month or so:

let g:nnn#action = { 'l': 'e' }

Then the plugin does it's job: it opens files by pressing l, but this approach sucks, because when I try to filter files with / inside NNN and hit l while typing the file name, that contains the letter l, it picks the first file in the filtered list while I am still typing the name. That's a bit of inconvenience here.

Recently I decided to give a try to luukvbaal/nnn.nvim but I did not found a way to make it select files by pressing l. The attempt to figure it out led me right down to NNN source code where I ended up with a solution:

diff --git a/src/nnn.c b/src/nnn.c
index 416e0ca8..25eeaeef 100644
--- a/src/nnn.c
+++ b/src/nnn.c
@@ -7145,7 +7145,7 @@ nochange:
 			}
 #endif
 			/* If opened as vim plugin and Enter/^M pressed, pick */
-			if (g_state.picker && (sel == SEL_OPEN)) {
+			if (g_state.picker && (sel == SEL_OPEN || sel == SEL_NAV_IN)) {
 				if (nselected == 0) /* Pick if none selected */
 					appendfpath(newpath, mkpath(path, pent->name, newpath));
 				return EXIT_SUCCESS;

It works perfectly and I would like to submit it by opening a PR, but there is another place in the source code above it, under the #ifndef NOFIFO, that looks similar. The functionality implemented there can probably benefit from adding sel == SEL_NAV_IN too, but I am completely unaware of what fifomode is (except that it is activated by -F1 option) and what is the use case of it. My confusion is the reason why I open this discussion.

Is this a valid approach at all? Maybe I am missing something, since I am new to the project. And what about fifomode? Is it the same thing or is it a different story?

[Oxore]

Oh, wow, I figured out the fifomode: it is used by NnnExplorer which I usually do not find useful. It acts the same way as NnnPicker function, but in side panel and yes, it would be hell of a pain for me to use it if it would not open files by pressing l. So I must consider changing this line too in the final PR.

The question about validation remains: does this whole approach align with the project's goals or it should be done in some other way, maybe not even in the NNN's source code?

[Oxore]

Here is basically a use case for opening a file by pressing l in picker mode of fifomode (from #1832 (comment)):

Because it's convenient to be able to open a file from that mode. Because nnn is after all a file manager. Say you are editing a file in vim and you want to listen to some music. You can use the plugin in picker mode and play it.

It somewhat answers the original question, but I should figure out whether would the new behavior of picking files by pressing l be acceptable if implemented as an option.