From 5b722dc76495dedb7f2719719b10259373e714f5 Mon Sep 17 00:00:00 2001 From: Jason Grout Date: Fri, 11 Oct 2019 22:59:03 -0700 Subject: [PATCH] Allow shortcuts to be empty and to have win/mac/linux-specific keys. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Phosphor allows shortcuts to be empty, and it’s the only way to have platform-specific shortcuts (define keys to be [], and the platform keys to be something specific). See https://github.com/phosphorjs/phosphor/issues/438 for some discussion. --- packages/shortcuts-extension/schema/shortcuts.json | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/packages/shortcuts-extension/schema/shortcuts.json b/packages/shortcuts-extension/schema/shortcuts.json index d4c849594d7c..776a2d9685f4 100644 --- a/packages/shortcuts-extension/schema/shortcuts.json +++ b/packages/shortcuts-extension/schema/shortcuts.json @@ -22,7 +22,18 @@ "command": { "type": "string" }, "keys": { "items": { "type": "string" }, - "minItems": 1, + "type": "array" + }, + "winKeys": { + "items": { "type": "string" }, + "type": "array" + }, + "macKeys": { + "items": { "type": "string" }, + "type": "array" + }, + "linuxKeys": { + "items": { "type": "string" }, "type": "array" }, "selector": { "type": "string" }