-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync bot crushing partial reviews #3744
Comments
Hmm, I did not change bot behavior. |
Sorry to tell you this, @iliakan Here, bot reverted my test change It is doing it regularly, with every new sync PR |
So if you do the changes locally, does this kind of resolve the issue? Trying to get if I need to do something. P.S. Initially, the idea was that edits are done locally. I hope things work this way. |
Yes, , now that I know of it. But the bot behavior is odd. I have a bot-sync example from 2 years ago: I made changes to the bot PR branch, online. |
Out of curiosity Plus if you use the bot's PR locally, you'll lose track of fast-forward modifications, meaning all inserted new text. |
Hi @iliakan
I discovered this in the Spanish repo,
but happens in the other repos too.
...
Previously, the bot used different branches for sync, closing the old PR and generating a new one over a new branch. Partial reviews were preserved in the closed PR.
Now, the bot closes the old PR but always uses the same branch, doing a force push on it that destroys any partial reviews.
The text was updated successfully, but these errors were encountered: