Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync bot crushing partial reviews #3744

Open
joaquinelio opened this issue Aug 7, 2024 · 6 comments
Open

Sync bot crushing partial reviews #3744

joaquinelio opened this issue Aug 7, 2024 · 6 comments

Comments

@joaquinelio
Copy link
Member

joaquinelio commented Aug 7, 2024

Hi @iliakan

I discovered this in the Spanish repo,
but happens in the other repos too.
...

Previously, the bot used different branches for sync, closing the old PR and generating a new one over a new branch. Partial reviews were preserved in the closed PR.

Now, the bot closes the old PR but always uses the same branch, doing a force push on it that destroys any partial reviews.

@iliakan
Copy link
Member

iliakan commented Aug 7, 2024

Hmm, I did not change bot behavior.

@joaquinelio
Copy link
Member Author

Ok
Maybe AI war started. Dont use my reasoning.
Look at this:

This is my work 2 years ago.
Bot closed it twice, I reopened it and continued working until I eventually merged

Screenshot_2024-08-07-16-34-43-341


Now the bot, AFTER closing it, did a force push erasing my commits

Screenshot_2024-08-07-16-51-35-345

@joaquinelio
Copy link
Member Author

Hmm, I did not change bot behavior.

Sorry to tell you this, @iliakan
The world bot vs human war started, in your repo.

Here, bot reverted my test change

Screenshot_2024-08-12-12-19-15-740

It is doing it regularly, with every new sync PR

Screenshot_2024-08-12-11-46-16-279

@iliakan
Copy link
Member

iliakan commented Aug 12, 2024

So if you do the changes locally, does this kind of resolve the issue?

Trying to get if I need to do something.

P.S. Initially, the idea was that edits are done locally. I hope things work this way.

@joaquinelio
Copy link
Member Author

Yes,
I can avoid the issue easily.

, now that I know of it.
Not a catastrophic bug anymore.


But the bot behavior is odd.

I have a bot-sync example from 2 years ago:

I made changes to the bot PR branch, online.
The bot closed it.
I reopened it and merged my changes, it worked as expected.

@joaquinelio
Copy link
Member Author

Out of curiosity
If local,
I do my own merges so I dont need to search <<< === >>> manually.

Plus

if you use the bot's PR locally, you'll lose track of fast-forward modifications, meaning all inserted new text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants