Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could jbang-vscode offer to install jbang if it is not available? #53

Open
maxandersen opened this issue Jan 12, 2023 · 6 comments
Open

Comments

@maxandersen
Copy link

its all nice downloading jbang + jbang edit gives you full dev environment but
it would be nice if jbang-vscode could offer to install jbang to make it easy to start from downloading vscode instead of installing script via terminal.

wdyt?

@fbricon
Copy link
Collaborator

fbricon commented Jan 13, 2023

Yeah I thought about it, also to embed jbang by default.
Where should we install it by default? ~/.jbang?

@maxandersen
Copy link
Author

yeah - I was thinking to just do what curl -Ls https://sh.jbang.dev | bash -s - app setup does.

for windows its a bit more tricky as it might require elevated privileges due to reliance on symbolic linking ;/

@maxandersen
Copy link
Author

/cc @quintesse

@maxandersen
Copy link
Author

I would be -1 on embedding jbang by default; unless its just used as absolute last fallback or we can release vscode-jbang immediately when jbang updates.

@fbricon
Copy link
Collaborator

fbricon commented Jan 18, 2023

yeah - I was thinking to just do what curl -Ls https://sh.jbang.dev | bash -s - app setup does.

for windows its a bit more tricky as it might require elevated privileges due to reliance on symbolic linking ;/

So do you want that we run curl / iex from vscode to trigger the install in a terminal, or do you have something else in mind?

@fbricon
Copy link
Collaborator

fbricon commented Jan 18, 2023

... like detect if sdkman, homebrew, choco is installed and delegate the JBang installation to those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants