From a91a2642d9d65361d4b469843649577a33aafdd4 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 11 Dec 2023 13:29:15 +0000 Subject: [PATCH 1/3] Bump edu.hm.hafner:codingstyle-pom from 3.39.0 to 3.40.0 Bumps [edu.hm.hafner:codingstyle-pom](https://github.com/uhafner/codingstyle-pom) from 3.39.0 to 3.40.0. - [Release notes](https://github.com/uhafner/codingstyle-pom/releases) - [Changelog](https://github.com/uhafner/codingstyle-pom/blob/main/CHANGELOG.md) - [Commits](https://github.com/uhafner/codingstyle-pom/compare/v3.39.0...v3.40.0) --- updated-dependencies: - dependency-name: edu.hm.hafner:codingstyle-pom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 1e31ea94..29714b88 100644 --- a/pom.xml +++ b/pom.xml @@ -7,7 +7,7 @@ edu.hm.hafner codingstyle-pom - 3.39.0 + 3.40.0 From 10bb0072105ea221f56d9bb2597fbcc0aecc6f40 Mon Sep 17 00:00:00 2001 From: Ulli Hafner Date: Wed, 13 Dec 2023 14:28:06 +0100 Subject: [PATCH 2/3] Fix CheckStyle warning. --- src/main/java/edu/hm/hafner/coverage/Metric.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/java/edu/hm/hafner/coverage/Metric.java b/src/main/java/edu/hm/hafner/coverage/Metric.java index cbd6732b..1ff8db66 100644 --- a/src/main/java/edu/hm/hafner/coverage/Metric.java +++ b/src/main/java/edu/hm/hafner/coverage/Metric.java @@ -162,7 +162,6 @@ private boolean hasCoverage(final Node node, final Metric metric) { return node.getValue(metric) .filter(value -> ((Coverage) value).getCovered() > 0) .isPresent(); - } @Override From f064356e3d55d5830f3c36e46a7656028c7d850e Mon Sep 17 00:00:00 2001 From: Ulli Hafner Date: Wed, 13 Dec 2023 15:14:33 +0100 Subject: [PATCH 3/3] Fix CheckStyle empty line warnings in tests. --- src/test/java/edu/hm/hafner/coverage/MutationTest.java | 1 - src/test/java/edu/hm/hafner/coverage/NodeTest.java | 3 --- .../edu/hm/hafner/coverage/parser/CoberturaParserTest.java | 2 -- .../edu/hm/hafner/coverage/parser/TestCaseMappingTest.java | 1 - 4 files changed, 7 deletions(-) diff --git a/src/test/java/edu/hm/hafner/coverage/MutationTest.java b/src/test/java/edu/hm/hafner/coverage/MutationTest.java index 15c1c834..5b43caa8 100644 --- a/src/test/java/edu/hm/hafner/coverage/MutationTest.java +++ b/src/test/java/edu/hm/hafner/coverage/MutationTest.java @@ -101,7 +101,6 @@ void shouldBuildAndAddToModule() { assertThat(moduleNode.getAllFileNodes().get(0)) .hasName("Class.java") .hasMutations(mutationBuilder.build()); - } @Test diff --git a/src/test/java/edu/hm/hafner/coverage/NodeTest.java b/src/test/java/edu/hm/hafner/coverage/NodeTest.java index feb1e4ad..e51b804c 100644 --- a/src/test/java/edu/hm/hafner/coverage/NodeTest.java +++ b/src/test/java/edu/hm/hafner/coverage/NodeTest.java @@ -150,7 +150,6 @@ void shouldReturnAllNodesOfSpecificMetricType() { assertThat(parent.getAll(FILE)) .hasSize(2) .containsOnly(childOfChildOne, childOfChildTwo); - } private static Coverage getCoverage(final Node node, final Metric metric) { @@ -325,7 +324,6 @@ void shouldKeepChildNodesAfterCombiningReportWithSamePackage() { Node combinedReport = module.merge(sameModule); assertThat(combinedReport.getChildren().get(0)).hasOnlyChildren(fileToKeep, otherFileToKeep); - } @Test @@ -704,7 +702,6 @@ void shouldMergeWithDuplicateAndDifferentNames() { .hasMetric(CONTAINER); assertThat(merged.getChildren()).hasSize(2); - } @Test diff --git a/src/test/java/edu/hm/hafner/coverage/parser/CoberturaParserTest.java b/src/test/java/edu/hm/hafner/coverage/parser/CoberturaParserTest.java index c888c085..c4c79961 100644 --- a/src/test/java/edu/hm/hafner/coverage/parser/CoberturaParserTest.java +++ b/src/test/java/edu/hm/hafner/coverage/parser/CoberturaParserTest.java @@ -27,7 +27,6 @@ @DefaultLocale("en") class CoberturaParserTest extends AbstractParserTest { - private static final int COVERED_LINES = 20 + 17 + 6 + 12 + 7; private static final int MISSED_LINES = 8 + 1 + 1 + 10; @@ -255,7 +254,6 @@ void shouldReadCoberturaAggregation() { assertThat(p.getAll(CLASS)).extracting(Node::getName).contains("env.ts"); } ); - } @Test @Issue("jenkinsci/code-coverage-api-plugin#473") diff --git a/src/test/java/edu/hm/hafner/coverage/parser/TestCaseMappingTest.java b/src/test/java/edu/hm/hafner/coverage/parser/TestCaseMappingTest.java index 1187e5c6..68dcd99c 100644 --- a/src/test/java/edu/hm/hafner/coverage/parser/TestCaseMappingTest.java +++ b/src/test/java/edu/hm/hafner/coverage/parser/TestCaseMappingTest.java @@ -106,5 +106,4 @@ private ModuleNode readReport(final String fileName, final CoverageParser parser throw new AssertionError(e); } } - }