Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contrast with 'ansi-xx-d' console colourisation. #59

Open
timbrown5 opened this issue Nov 8, 2022 · 0 comments
Open

Improve contrast with 'ansi-xx-d' console colourisation. #59

timbrown5 opened this issue Nov 8, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@timbrown5
Copy link
Contributor

timbrown5 commented Nov 8, 2022

Jenkins and plugins versions report

Environment
Paste the output here

What Operating System are you using (both controller, and any agents involved in the problem)?

Any OS or browser.

Reproduction steps

  1. Install Pipeline Graph View Plugin.
  2. Ensure ANSI Plugin global setting is disabled.
  3. Write a Pipeline that outputs ANSI codes, e.g.
pipeline {
    agent none
    options {
        ansiColor('xterm')
    }
    stages {
        stage('Color') {
            steps {
                echo('\033[34mHello\033[0m \033[33mcolorful\033[0m \033[35mworld\033[0m')
            }
        }
    }
}
  1. Run Pipeline
  2. View console text in Pipeline Console.

Expected Results

Readable text, e.g.
Screenshot 2022-11-08 at 14 17 30

or:
Screenshot 2022-11-08 at 14 17 40

Actual Results

Text is difficult to read:
Screenshot 2022-11-08 at 14 17 50

Anything else?

We could look at using similar colours to the Dark Theme:
https://github.com/jenkinsci/dark-theme-plugin/blob/master/src/main/frontend/main.scss

The classes to override are defined in:
https://github.com/jenkinsci/pipeline-graph-view-plugin/blob/main/src/main/frontend/pipeline-console-view/pipeline-console/main/pipeline-console.scss#L92

@timbrown5 timbrown5 added the bug Something isn't working label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant