Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display still not cleaning #104

Closed
alkanna opened this issue Dec 22, 2017 · 9 comments
Closed

Display still not cleaning #104

alkanna opened this issue Dec 22, 2017 · 9 comments

Comments

@alkanna
Copy link

alkanna commented Dec 22, 2017

Self explanatory, display is still not cleaning properly since last update, you can only use the checker if you remember the right keybinds, otherwise you can't see most of them.

@cbcercas
Copy link
Contributor

What os are you using?
my PR #103 to fix #101 broke this can you try this:
in includes/utils/utils.sh line 255
replace tput ed by tput cd

@alkanna
Copy link
Author

alkanna commented Dec 23, 2017

It works, thanks !
Using Sierra on 42 Paris campus iMacs.

@cbcercas
Copy link
Contributor

Ok, I don't have a mac, so can you try my new fix here https://github.com/cbcercas/42FileChecker/tree/bugfix--display-not-cleaning

@Seluj78
Copy link
Collaborator

Seluj78 commented Dec 26, 2017

I just tried your new fix @cbcercas on a cluster and it doenst work :/
screen shot 2017-12-26 at 1 24 09 pm

@jgigault
Copy link
Owner

jgigault commented Dec 26, 2017

Maybe:

tput ed 2>/dev/null
tput cd 2>/dev/null

If both work on different platforms?

@wbaridon
Copy link

wbaridon commented Dec 29, 2017

On cluster your fix duplicate the line (white line then green line). But if you put:
tput cup 0 0
tput cd 2>/dev/null
It's okay.

@jgigault
Copy link
Owner

je viens de push ccf8d39
peux-tu me dire si ça fix le soucis stp ?
sur d'autres terminaux la requête cd ne fonctionne pas (#101)

@Seluj78
Copy link
Collaborator

Seluj78 commented Jan 1, 2018

@jgigault Je viens de tester sur Ubuntu bash pour windows avec oh-my-zsh, commande bash ./42FileChecker` et aucun probleme, a par la lenteur de mon term mais c'est client side.

Si j'y penses je teste demain a 42

@Seluj78 Seluj78 mentioned this issue Jan 2, 2018
@Seluj78
Copy link
Collaborator

Seluj78 commented Feb 5, 2018

#84

@Seluj78 Seluj78 closed this as completed Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants