Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Invalid externs for Quill #30

Open
smogg opened this issue Oct 17, 2016 · 3 comments
Open

Invalid externs for Quill #30

smogg opened this issue Oct 17, 2016 · 3 comments

Comments

@smogg
Copy link

smogg commented Oct 17, 2016

Generating externs for Quill 1.1.0 doesn't include methods from Quill API. It also generates invalid js:

Quill.imports / formats / list / item.prototype = { ....

Which was generated based on this source from Quill:

_core2.default.register({
  ...
  'formats/list/item': _list.ListItem,
@jmmk
Copy link
Owner

jmmk commented Oct 19, 2016

@smogg thanks for the report.

Interesting, I guess the correct JS is:

Quill['imports']['formats/list/item'].prototype = { ...

but I don't think this is valid in an extern. In that case, perhaps these can be excluded from the extern altogether (somewhat related to #22). Not sure.

As for the Quill API functions... it looks like they are instance methods (new Quill().deleteText()) rather than being static calls (Quill.deleteText()) which I currently don't handle. I'm not 100% sure that those need to be in an extern, but #29 seems to provide some evidence that they do.

@dfrese
Copy link

dfrese commented Jan 26, 2017

Same for the "ACE Editor" (https://ace.c9.io/), btw.

@jmmk
Copy link
Owner

jmmk commented Nov 11, 2018

I've fixed the invalid format in 0fcc0df

instance methods are still not handled

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants