Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to construct a UNIXSocket or server with existing fd #4

Closed
headius opened this issue Aug 2, 2013 · 3 comments
Closed

Comments

@headius
Copy link
Member

headius commented Aug 2, 2013

For jruby/jruby#940, we need a factory method or constructor method exposed that can take an existing fd.

@mrbrdo
Copy link

mrbrdo commented Nov 24, 2015

@headius need this for spring to work... I can't invoke the fd, opts constructor from JRuby. I wasn't even able to do it with getDeclaredConstructor (maybe some derp), but I finally managed to totally hack it with getDeclaredConstructors. So I know in fact it will work (tested it), just need to expose it to JRuby and use it for UNIXSocket.for_fd. I think UNIXSocket.for_fd is returning something right now, but it's not correct as it doesn't work.

FYI this is the (terrible) hack I used for testing: https://gist.github.com/mrbrdo/e5bcd63e0688422fb69b

@headius
Copy link
Member Author

headius commented Nov 24, 2015

I'll get something basic in today so we can release this and you can update rails/spring#449 to use it.

@headius
Copy link
Member Author

headius commented Nov 24, 2015

jnr-unixsocket 0.10 is released. It will be incorporated into JRuby 9.0.5.0 and is already being used on JRuby master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants