-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with the defaults tests when dashboard
-route doesn't exists.
#384
Comments
Hey @FoksVHox! We're sorry to hear that you've hit this issue. 💙 However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue? We need a public GitHub repository which contains a Laravel app with the minimal amount of Socialstream code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly. |
Thank you for providing reproduction steps! Reopening the issue now. |
@FoksVHox I've created a PR for this, please can you install into your reproduction repository and check this works? |
@joelbutcher It's fixed on the pr branch. |
@FoksVHox this has now been fixed in v6.1.11. Please update your composer dependencies to this version to see you issue has been rectified!🧑💻 |
@joelbutcher Thank you so much! |
Stack
Breeze – React with Inertia
Package Version
v6.1.9
Laravel Version
v11.30
Livewire Version
No response
react Version
v18.2.0
Vue Version
No response
PHP Version
PHP 8.2
Problem description
When you've changed the route for
/dashboard
in the config, and remove the/dashboard
, then the tests starts to fail.The problem is at this line, as it's expecting it to be called 'dashboard'. I've also opened a discussion about it
socialstream/src/Http/Responses/OAuthRegisterResponse.php
Line 28 in 42b4341
Expected behavior
I'd expect that I don't need the
/dashboard
to have the tests working.Steps to reproduce
/dashboard
, could use/
as the redirect route./dashboard
routeReproduction repository
https://github.com/FoksVHox/socialstream-bug-report-384
Relevant log output
The text was updated successfully, but these errors were encountered: