Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop overwriting settings.json every time I restart VScode #559

Open
fritz-trawa opened this issue Nov 27, 2024 · 3 comments
Open

Stop overwriting settings.json every time I restart VScode #559

fritz-trawa opened this issue Nov 27, 2024 · 3 comments

Comments

@fritz-trawa
Copy link

Versions (please complete the following information):

  • OS: [e.g. mac] mac

  • VS Code version [e.g. 1.37.0-insiders]
    Version: 1.96.0-insider
    Commit: ba849fc973f4d6f7421a9ef5d0433aa879ae3c7d
    Date: 2024-11-26T21:12:34.712Z
    Electron: 32.2.5
    ElectronBuildId: 10579404
    Chromium: 128.0.6613.186
    Node.js: 20.18.0
    V8: 12.8.374.38-electron.0
    OS: Darwin arm64 23.6.0

  • Peacock Version 4.2.2

Describe the bug

To Reproduce

  1. Wait for the "Restart to Update (1)" alert to appear and restart
  2. The workspace settings file is opened and unsaved
  3. Open the palette and run the command "File: Compare unsaved file to saved"
  4. Notice that all the changes are from Peacock

Expected behavior
Please leave my settings alone, it's an unnecessary distraction. Until I discovered the "File: Compare unsaved file to saved" command I wasted a lot of time understanding what was going on

Or else be explicit and show some sort of alert that tells me that you are changing settings x and y because of z so I know what is going on. Thanks

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@willpower232
Copy link
Contributor

If you have achieved the colour palette you want then presumably you can remove the peacock.color line from the settings file so it just leaves the workbench.colorCustomizations alone and nothing changes any further?

@fritz-trawa
Copy link
Author

fritz-trawa commented Nov 27, 2024

Tried that, if I remove peacock.color and save all the workbench.colorCustomizations disappear

EDIT: thanks for the swift reply btw

@willpower232
Copy link
Contributor

Oh I hadn't noticed that, that is annoying. I presume the only real solution is to disable it for the workspace then but it would be nice if it didn't assume ownership of the settings 😅

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants