Make sure the first segment is not empty or it's not complete (is current) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, Nikolay. I merged it. I'm looking for someone who is
interested in taking over maintenance of this repository.
…On Wed, Oct 23, 2024 at 4:28 AM Nikolay Dimitrov ***@***.***> wrote:
In an edge case, on load, we found that it is possible to have the first
segment being empty (size()==0) and also complete (reached
q.config.ItemsPerSegment limit).
In such queue, the Peek() and Deque() return error 'empty', but that is
not correct as the queue has another segment with available objects.
------------------------------
You can view, comment on, or merge this pull request online at:
#40
Commit Summary
- cba597b
<cba597b>
Make sure the first segment is not empty or it's not complete (is current)
File Changes
(2 files <https://github.com/joncrlsn/dque/pull/40/files>)
- *A* queue
<https://github.com/joncrlsn/dque/pull/40/files#diff-00b109cf1123a591253cc534b17e5268eb8fc2fbb7d6772de7a55c135ef1282f>
(0)
- *M* queue.go
<https://github.com/joncrlsn/dque/pull/40/files#diff-979cedf61ccaba8f637a393ae99a88eae86eeb9817cab20e334a25a825913695>
(19)
Patch Links:
- https://github.com/joncrlsn/dque/pull/40.patch
- https://github.com/joncrlsn/dque/pull/40.diff
—
Reply to this email directly, view it on GitHub
<#40>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA7KRH53OAYEGS3ZCC6OF3Z45T2ZAVCNFSM6AAAAABQOLS3WKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYYDOOBZHE2TSNY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
When the whole world is running towards a cliff, he who is running in the
opposite direction appears to have lost his mind.
<https://www.azquotes.com/quote/850693>
- C.S. Lewis
|
|
Hi, Jon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an edge case, on load, we found that it is possible to have the first segment being empty (size()==0) and also complete (reached q.config.ItemsPerSegment limit).
In such queue, the Peek() and Deque() return error 'empty', but that is not correct as the queue has another segment with available objects.