Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Copy with included titles compatible with Paste #25

Open
cheater opened this issue Jul 12, 2020 · 0 comments
Open

Make Copy with included titles compatible with Paste #25

cheater opened this issue Jul 12, 2020 · 0 comments

Comments

@cheater
Copy link

cheater commented Jul 12, 2020

Currently if you use the Copy function with "include titles" enabled, and then use the Paste function, the titles will be opened as separate tabs.

Currently the "Include titles" option creates strings of the following format:

https://github.com/joshdick/tabclip/issues/new | New Issue · joshdick/tabclip
https://www.google.com/ | Google

However, if you made it like this:

https://github.com/joshdick/tabclip/issues/new # New Issue · joshdick/tabclip
https://www.google.com/ # Google

and made tabclip ignore everything after a space and a # sign, then that would fix the issue. It feels like it's probably safe to ignore stuff after such a string. However, you do allow the literal space as part of a URL, which may make it confusing for people when they try to paste a URL that does contain a literal space followed by a # sign. On the other hand, the literal space normally never shows up in URLs - links escape those as + or as %20. When you copy URLs out of the address bar, the same thing happens. Finally, tabclip itself escapes those as %20 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant