Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"live" streaming (Rails 4.x) likely broken #150

Open
kares opened this issue Mar 5, 2013 · 5 comments
Open

"live" streaming (Rails 4.x) likely broken #150

kares opened this issue Mar 5, 2013 · 5 comments
Milestone

Comments

@kares
Copy link
Member

kares commented Mar 5, 2013

due magic-threading in ActionController::Live "middleware" ...

This issue seems to be lacking activity, you can change that by posting a bounty.

@WiseMaestro
Copy link

I can confirm that this causes my application (using trinidad) to deadlock.

Would it be possible to use java threads as a drop in replacement for "magic-threading" (what does that mean?) to get this to work?

@kares
Copy link
Member Author

kares commented Dec 14, 2013

Ruby threads use Java threads the problem is the way they're used in Rails - simply not "thread-safe" code.
For Trinidad/JRuby-Rack there would be a better solution to this leveraging servlet async support - ideally Rails core would hide the threaded impl under some class that could than be replaced at runtime - so it's some work to be done, go for it!

@loganb
Copy link

loganb commented Dec 16, 2013

Is the nature of the problem documented with greater detail anywhere? I'm trying to understand what part of the Live middleware is thread-unsafe.

@kares
Copy link
Member Author

kares commented Dec 16, 2013

it dead locks - that's all there is (for now) ... I have not looked deeper and I have not tracked if anyone else did ... sorry

@kares kares changed the title streaming (Rails 4.0) likely broken "live" streaming (Rails 4.x) likely broken Jul 24, 2014
@kares kares added this to the 1.2.0 milestone Aug 22, 2014
@kares kares mentioned this issue Nov 17, 2015
34 tasks
@rthbound
Copy link

rthbound commented Mar 5, 2016

Has anyone tried this against the rails 5 betas?
http://weblog.rubyonrails.org/2016/2/27/Rails-5-0-beta3/

@headius headius modified the milestones: 1.2.0, 1.2.1 May 23, 2024
@headius headius modified the milestones: 1.2.1, 1.2.2, 1.2.3 Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants