Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update speaker page #24

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

techmannih
Copy link
Contributor

close #22

@techmannih
Copy link
Contributor Author

@DhairyaMajmudar @benjagm @valeriahhdez Please review this PR

@DhairyaMajmudar DhairyaMajmudar self-requested a review December 16, 2024 08:39
@Honyii
Copy link

Honyii commented Dec 16, 2024

@techmannih thanks for the task done, however there is an inconsistency to the presentation title. The expectation is that the title should be in sentence case i.e;

a. State of JSON Schema
b. IEC Standards: Toward Digital Standards with JSON Schema
c. Applying Software Engineering Practices to JSON Schemas
d. High Performance JSON Schema Validation in .NET
e. JSON Schema and Relational Databases: Bridging the Gap!
f. Unlocking Dynamic Frontend Development Through JSON Schema
g. Introducing Strands - A JSONSchema Repository
h. Generic and Extensible Web of Things Manager Using JSON Schema & AI
i. JSON Schema for Data Design and Contract, Client, and Code Generation
j. JSON Schema: Powering FINOS Architecture as Code

  1. Capitalizing "Ambassador" in content/speakers/andreas.md.
  2. The presentation slide should be in the static folder of the repo in a subfolder and not a dropbox link.
    cc @benjagm can you explain further on this for more clarification.

@techmannih
Copy link
Contributor Author

@Honyii when I try to add the slide statically, it redirects to an invalid URL.

@Honyii
Copy link

Honyii commented Dec 17, 2024

@techmannih so it has to do with the way you are referencing the pdf file. Here is how you can resolve this;

  • We have an existing static folder
  • Create another folder where you'd store all pdfs
  • Now go to the sessions folder and reference it there, for example you want to reference the presentation for "IEC Standards - Toward digital standards with JSONSchema."
  • It should be "presentation: /{{the folder name where all pdfs are stored}}/{{name of the pdf file}}".

This should fix the referencing blocker and for more clarification, you can check the screenshot shared here to use as an example structure.

Screenshot 2024-12-17 at 18 59 38 Screenshot 2024-12-17 at 18 59 48

@techmannih
Copy link
Contributor Author

@Honyii Yes I was doing same but it's not work

20241217233817.mp4

@Honyii
Copy link

Honyii commented Dec 17, 2024

That's weird, I just followed the steps I shared and it's working on my end. We can have a short call tomorrow and figure out why yours is failing if you do not mind.

@techmannih
Copy link
Contributor Author

techmannih commented Dec 18, 2024

@Honyii I have fixed the Dropbox link with the static folder, and it's working fine now. Please check now

@Honyii
Copy link

Honyii commented Dec 18, 2024

Looks good on my end and
Cc @benjagm @DhairyaMajmudar can have a second look incase anything was missed.

@DhairyaMajmudar
Copy link
Member

Thank you so much @Honyii for the review

Amazing PR @techmannih listing some suggestions to work upon

  1. In some speaker session pages the slide tab is getting merged with footer. You can fix this by adding some bottom margin

image

  1. The avatar image of James Gough is missing

image

  1. Let's keep the card of Neha Singla to be squared-shaped maintaining the consistency with the grid.

image

  1. I'm getting a completely blank presentation slide for Tom Collins's Talk. Pls. confirm if you're facing the same

@techmannih
Copy link
Contributor Author

techmannih commented Dec 18, 2024

@DhairyaMajmudar Thanks for pointing that out! Yes, the presentations by Tom Collins and Andreas Eberhart had a different format compared to the others. I’ve fixed them now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update speakers page
3 participants