-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update speaker page #24
base: main
Are you sure you want to change the base?
Conversation
@DhairyaMajmudar @benjagm @valeriahhdez Please review this PR |
@techmannih thanks for the task done, however there is an inconsistency to the presentation title. The expectation is that the title should be in sentence case i.e; a. State of JSON Schema
|
@Honyii when I try to add the slide statically, it redirects to an invalid URL. |
@techmannih so it has to do with the way you are referencing the pdf file. Here is how you can resolve this;
This should fix the referencing blocker and for more clarification, you can check the screenshot shared here to use as an example structure. |
@Honyii Yes I was doing same but it's not work 20241217233817.mp4 |
That's weird, I just followed the steps I shared and it's working on my end. We can have a short call tomorrow and figure out why yours is failing if you do not mind. |
@Honyii I have fixed the Dropbox link with the static folder, and it's working fine now. Please check now |
Looks good on my end and |
Thank you so much @Honyii for the review Amazing PR @techmannih listing some suggestions to work upon
|
@DhairyaMajmudar Thanks for pointing that out! Yes, the presentations by Tom Collins and Andreas Eberhart had a different format compared to the others. I’ve fixed them now. |
close #22