JUBE-2-Create-Authentication-Page #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o that it can be reused by the Blazor user interface. Moved validations for the Authentication processing into a dedicated class, for reuse also. Ported the authentication page to Blazor using more modern design patterns, relying on DI and declarations where possible. Some modifications to Dto's affecting the Authentication Controller in Jube.App (current version). Implemented resource localisation in the Blazor user interface, although its implementation in Validations is pending. Implemented a declarative policy authentication for pages, although intend to explore ways to reference the claim directly in the Authorize attribute (e.g. [Authorize Claim(Permission,1)]) rather than relying on Policy, which depends on claims anyway. Some typo changes and nullable field refactoring implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved logic in the Authentication Controller to a dedicated service so that it can be reused by the Blazor user interface. Moved validations for the Authentication processing into a dedicated class, for reuse also. Ported the authentication page to Blazor using more modern design patterns, relying on DI and declarations where possible. Some modifications to Dto's affecting the Authentication Controller in Jube.App (current version). Implemented resource localisation in the Blazor user interface, although its implementation in Validations is pending. Implemented a declarative policy authentication for pages, although intend to explore ways to reference the claim directly in the Authorize attribute (e.g. [Authorize Claim(Permission,1)]) rather than relying on Policy, which depends on claims anyway. Some typo changes and nullable field refactoring implemented.