Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Adding type annotation and add MyPy in CI #389

Open
darnuria opened this issue Dec 18, 2022 · 1 comment
Open

Improvement: Adding type annotation and add MyPy in CI #389

darnuria opened this issue Dec 18, 2022 · 1 comment

Comments

@darnuria
Copy link
Contributor

Hello pretty much in the Title, if pertinent I can try to work on that modestly.

  • Add types annotations (try to avoid requirement on too-high python version)
  • Add mypy in CI to check theses (i am new with github action)

I know that some function signature would be hairy but it's okay, will help discovering possibility I think, right now it's often necessary to jump into the source to know what exactly a function accept.

@julien-duponchelle
Copy link
Owner

Happy to to get this contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants