Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieving the whole history #181

Open
jtpio opened this issue Aug 30, 2019 · 1 comment
Open

Retrieving the whole history #181

jtpio opened this issue Aug 30, 2019 · 1 comment

Comments

@jtpio
Copy link
Member

jtpio commented Aug 30, 2019

At the moment xeus defaults to 10 entries for the history when n is not specified: https://github.com/QuantStack/xeus/blob/871cfd3993b63b725ef98a0a597ce534ac05e387/src/xhistory_manager.cpp#L40

To get the whole history at once, clients can pass a very high number, such as 10000, assuming the history has less than 10000 entries.

But when that number is bigger than what can fit in an int, it defaults to 0. Maybe n could in that case default to the size of the history?

@jtpio
Copy link
Member Author

jtpio commented Aug 30, 2019

An alternative way to get the whole history is to let the client do the paging itself, using range as hist_access_type and asking for 1000 entries at a time (for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant