Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaking frontend widgets #255

Open
AntoinePrv opened this issue Feb 3, 2023 · 0 comments
Open

Leaking frontend widgets #255

AntoinePrv opened this issue Feb 3, 2023 · 0 comments

Comments

@AntoinePrv
Copy link
Member

In xtarget, when a widget is created by the frontend:

void xobject_comm_opened(xeus::xcomm&& comm, const xeus::xmessage& msg)

it is added to the registry:
factory.make(std::move(comm), state, buffers);

m_makers.at(model_module + model_name + view_module + view_name)(std::move(comm), state, buffers);

get_transport_registry().register_owning(reinterpret_cast<xmaterialize<CRTP, P...>&&>(model));

But never removed. It should be destroyed when the comm is closed by the frontend.

However the way to do this is not clear. Tracking how to do it in jupyter-xeus/xeus#356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant