Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The slash / in branch name is not escaped #1010

Open
sighingnow opened this issue Jun 1, 2022 · 0 comments
Open

The slash / in branch name is not escaped #1010

sighingnow opened this issue Jun 1, 2022 · 0 comments

Comments

@sighingnow
Copy link

Hi! Thanks for using Jupyter Notebook Viewer (nbviewer) and taking the time to report a bug you've encountered. Please use the template below to tell us about the problem.

If you've found a bug in a different Jupyter project (e.g., Jupyter Notebook, JupyterLab, JupyterHub, etc.), please open an issue using that project's issue tracker instead.

If you need help using or installing Jupyter Notebook Viewer, please use the jupyter/help issue tracker instead.

Describe the bug

The / in branch name is not escaped properly. e.g.,

https://nbviewer.org/github/sighingnow/v6d/tree/main/

Selecting a branch with / in name will cause 404, but replace the / in the branch name part with %2F in the URL will open this branch correctly.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'https://nbviewer.org/github/sighingnow/v6d/tree/main/'
  2. Click on 'main' to select a branch, then choose dev/kubernetes
  3. Scroll down to '....'
  4. See error

Expected behavior

The / in branch name should be escaped.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant