Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch names are not url encoded #1059

Open
taylor-schneider opened this issue May 11, 2024 · 0 comments
Open

Branch names are not url encoded #1059

taylor-schneider opened this issue May 11, 2024 · 0 comments

Comments

@taylor-schneider
Copy link

taylor-schneider commented May 11, 2024

Describe the bug
The UI is not URL encoding branch names which leads to invalid URLs. For example, if the git repo has a branch named "feature/blah=blah" the UI will construct a url that contains "feature/blah-blah" rather than "feature%2fblah-blah"

To Reproduce
Steps to reproduce the behavior:

  1. Open website
  2. Try to view notebook in branch with special char in name (e.g. this notebook)

Expected behavior
The note book should load rather than send a 404

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 124.0.6367.201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant