Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impending deprecation notice and fix link for API #6920

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented Jun 13, 2023

Fixes #6680

@jtpio jtpio added this to the 6.5 milestone Jun 14, 2023
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


.. _JEP for Notebook 7: https://jupyter.org/enhancement-proposals/79-notebook-v7/notebook-v7.html
.. _Notebook documentation: https://jupyter-notebook.readthedocs.io/en/latest
.. _Nbclassic documentation: https://nbclassic.readthedocs.io/en/latest/nbclassic.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion for consistency:

Suggested change
.. _Nbclassic documentation: https://nbclassic.readthedocs.io/en/latest/nbclassic.html
.. _NbClassic documentation: https://nbclassic.readthedocs.io/en/latest/nbclassic.html

@jtpio
Copy link
Member

jtpio commented Jun 27, 2023

Thanks @RRosio this looks good 👍

Do you think it's ready to be undrafted and merged?

@RRosio RRosio marked this pull request as ready for review June 28, 2023 01:08
@RRosio
Copy link
Collaborator Author

RRosio commented Jun 28, 2023

Do you think it's ready to be undrafted and merged?

Thank you @jtpio! Yes I went ahead an un-drafted this!
The CI failures don't seem to be related. I'll go ahead and merge!

@RRosio RRosio merged commit 25bf597 into jupyter:6.5.x Jun 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants