From c3e1b8edb506bf8683d910866e63f98e8fe20ee5 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Wed, 9 Aug 2023 12:29:32 +0000 Subject: [PATCH 1/6] Add CI check to install with homebrew on `macos` --- .github/workflows/build.yml | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fe53675e48..e7f677cf92 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -167,6 +167,38 @@ jobs: jupyter notebook --version jupyter notebook --help + install-brew: + needs: [build] + runs-on: macos-latest + timeout-minutes: 15 + steps: + - name: Install Python + run: | + brew install python + - uses: actions/download-artifact@v3 + with: + name: notebook-dist-${{ github.run_number }} + path: ./dist + - name: Install the prerequisites + run: | + python -m pip install -U pip wheel + - name: Install the package + run: | + cd dist + python -m pip install -vv ${{ matrix.dist }} + - name: Validate environment + run: | + python -m pip freeze + python -m pip check + - name: Validate the install + run: | + jupyter labextension list + jupyter labextension list 2>&1 | grep -ie "@jupyter-notebook/lab-extension.*enabled.*ok" - + jupyter server extension list + jupyter server extension list 2>&1 | grep -ie "notebook.*enabled" - + jupyter notebook --version + jupyter notebook --help + check_links: runs-on: ubuntu-latest timeout-minutes: 10 From c01f74c153ccda6431d7cab64adf58f382fc48cd Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Wed, 9 Aug 2023 12:45:23 +0000 Subject: [PATCH 2/6] fix install command --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e7f677cf92..c82334f345 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -185,7 +185,7 @@ jobs: - name: Install the package run: | cd dist - python -m pip install -vv ${{ matrix.dist }} + python -m pip install -vv 'notebook*.whl' - name: Validate environment run: | python -m pip freeze From 34362921004b8c2abdb7125f9c20e79ce87e4301 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Wed, 9 Aug 2023 13:09:03 +0000 Subject: [PATCH 3/6] try python3 --- .github/workflows/build.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c82334f345..fea48d425f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -181,15 +181,15 @@ jobs: path: ./dist - name: Install the prerequisites run: | - python -m pip install -U pip wheel + python3 -m pip install -U pip wheel - name: Install the package run: | cd dist - python -m pip install -vv 'notebook*.whl' + python3 -m pip install -vv 'notebook*.whl' - name: Validate environment run: | - python -m pip freeze - python -m pip check + python3 -m pip freeze + python3 -m pip check - name: Validate the install run: | jupyter labextension list From 65d788e0609b73564bbeb477745cb369077a0776 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Wed, 9 Aug 2023 13:20:08 +0000 Subject: [PATCH 4/6] try without quotes --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fea48d425f..1b9772ac1c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -185,7 +185,7 @@ jobs: - name: Install the package run: | cd dist - python3 -m pip install -vv 'notebook*.whl' + python3 -m pip install -vv notebook*.whl - name: Validate environment run: | python3 -m pip freeze From 3cd348a1bae0b9fe89aabcc8c5170db56fa3e18c Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Thu, 10 Aug 2023 06:30:27 +0000 Subject: [PATCH 5/6] add browser check --- .github/workflows/build.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1b9772ac1c..2a71635acd 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -172,7 +172,7 @@ jobs: runs-on: macos-latest timeout-minutes: 15 steps: - - name: Install Python + - name: Install Python with Homebrew run: | brew install python - uses: actions/download-artifact@v3 @@ -198,6 +198,9 @@ jobs: jupyter server extension list 2>&1 | grep -ie "notebook.*enabled" - jupyter notebook --version jupyter notebook --help + - name: Browser check + run: | + python -m jupyterlab.browser_check --BrowserApp.default_url='/tree' check_links: runs-on: ubuntu-latest From a7b17c53e87b07c409f9c8d17064da38fbd73be0 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Thu, 10 Aug 2023 06:54:58 +0000 Subject: [PATCH 6/6] fix command --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2a71635acd..25e9b9bb9e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -200,7 +200,7 @@ jobs: jupyter notebook --help - name: Browser check run: | - python -m jupyterlab.browser_check --BrowserApp.default_url='/tree' + python3 -m jupyterlab.browser_check --BrowserApp.default_url='/tree' check_links: runs-on: ubuntu-latest