Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving JupyterLab launcher entries to the "other" category #145

Open
ian-r-rose opened this issue Sep 4, 2019 · 18 comments
Open

Comments

@ian-r-rose
Copy link
Collaborator

I find the placement of the launcher entries in JupyterLab in the "Notebook" section to be kind of weird, since they are mostly not notebooks. Why not put them in the "other" category?

@ian-r-rose
Copy link
Collaborator Author

Or, perhaps make the category configurable?

@manics
Copy link
Member

manics commented Sep 5, 2019

I think other makes sense.

@betatim
Copy link
Member

betatim commented Sep 5, 2019

Is it possible to add an additional category? The Other category is visually far away from where people look :-/

@madsi1m
Copy link

madsi1m commented May 4, 2020

I just made this, maybe it should go here? jupyterhub/jupyter-rsession-proxy#87

@ellisonbg
Copy link

Just ran into this - I think that JupyterLab should allow additional categories to be created by launcher items, otherwise using other would be helpful.

@yuvipanda
Copy link
Contributor

jupyterlab/jupyterlab#8663 is also an option. 'Other' puts everything below the fold, IMO, so we shouldn't put these there unless there is a way to make it more prominent.

@cmd-ntrf
Copy link
Contributor

I just finished reading the Jupyter blog post on Elyra and I found out they were able to add an Elyra category to JupyterLab:
image

The magic seems to be somewhere in here:
https://github.com/elyra-ai/elyra/blob/master/packages/theme/src/launcher.tsx

So it looks like with ~200 lines of code, we should be able to add a "Proxy Server" category to JupyterLab if we wish to.

@ryanlovett
Copy link
Collaborator

Nice! Yes, I'm in favor of "Proxy Server" or just "Proxy" category.

@eddienko
Copy link

eddienko commented Feb 7, 2021

I like the idea of the Elyra launcher. Has anybody tried it? I will give it a go if not....

I do not like "Proxy Server" (it does not mean much to users!). What about "Applications" -- maybe if it is a jupyterlab extension the title can be also customised.

@eddienko
Copy link

I have done a quick start on this, but likely needs help. It needs a few things:

The status is much WIP: "Works for me".

@MarcSkovMadsen
Copy link

My vote would go for adding jupyter-server-proxy items to an Application category (or one or more custom ones) just below the Notebook category.

In that way I could move the "Panel HighCharts Apps" to some more relevant location.

image

@claytonlemons
Copy link

Resurrecting an old thread...
I'm in favor of adding Jupyter Server Proxy launcher items to the "Application" category, as opposed to "Other". In fact, I would propose the following change to the launcher_entry config option:

launcher_entry:
    // no changes to these fields
    enabled: bool
    icon_path: str
    title: str

    // new optional field, where the default value is "Application"
    category: str

@eddienko What do you think?
I noticed you have a draft PR up. If you're OK with this^ proposal, would you like some help with making changes in the PR?

@psychemedia
Copy link

@claytonlemons @MarcSkovMadsen I'd +1 on being able to add server proxy applications to an Application or Applications area.

@yuvipanda
Copy link
Contributor

Yes I think an 'Application' field would be quite perfect.

@ellisonbg
Copy link

ellisonbg commented Apr 3, 2024 via email

@ryanlovett
Copy link
Collaborator

#453 enables the launcher category to be configurable. To satisfy this issue, the default category could be changed from "Notebook" to "Application".

@yuvipanda
Copy link
Contributor

#453 (comment) feels like a blocker to merging that though - we may lose icons?

@bollwyvl
Copy link
Collaborator

bollwyvl commented Apr 3, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests