Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should @microsoft/fast-components be vendored in this repo? #85

Closed
jtpio opened this issue Jan 9, 2024 · 3 comments
Closed

Should @microsoft/fast-components be vendored in this repo? #85

jtpio opened this issue Jan 9, 2024 · 3 comments

Comments

@jtpio
Copy link
Member

jtpio commented Jan 9, 2024

If so, is there a long-term plan that would not require to vendor @microsoft/fast-components in this repo?

And for this question?

Asking to get a better idea of the implications, and what that would mean in terms of maintenance work for maintainers in case this proposal is accepted: jupyterlab/frontends-team-compass#227

Originally posted by @jtpio in #80 (comment)

@jtpio
Copy link
Member Author

jtpio commented Jan 9, 2024

Opening a new issue for visibility, as the comment above was originally posted on an already merged PR.

@jtpio
Copy link
Member Author

jtpio commented Jan 12, 2024

There was some discussions about this during the previous JupyterLab call: jupyterlab/frontends-team-compass#229 (comment)

@fcollonval would you mind providing some information about this here in this issue, so it's easier to find and track in the future? Thanks!

@fcollonval
Copy link
Member

The fast library decided to focus on providing the tooling to create an adaptive and accessible components library; not the library itself. Therefore they deprecated the package @microsoft/fast-components. And it will be removed in the next major release. In the meantime the community started an substitute: https://github.com/Adaptive-Web-Community/Adaptive-Web-Components. But it is based on the prerelease of the next major iteration of Fast system. Therefore it was decided to import in this project the piece of @microsoft/fast-components (mainly the styling of them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants