Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "Open" filebrowser context menu item work with ".hdf5" files #3

Open
telamonian opened this issue Aug 19, 2019 · 0 comments
Open

Comments

@telamonian
Copy link
Member

telamonian commented Aug 19, 2019

I'm currently exploring some changes to core to make this happen. Some possibilities:

  • Introduce a dirlike filetype to go alongside directory and file in the core contents machinery. When you open a dirlike in the default filebrowser, it will switch to a particular browser, then use that browser's drive to cd to dirlike.path.

  • add contents handling callback to the optional filetype parameters. At some point in the 'filebrowser:open' command, in between getting an item and passing item.path to the next open command, have a hook for a callback like:

    (item: Contents.IModel): string => {
      <do stuff>
    
      return path;
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant