Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Lumino cross-compatiblity with React #334

Open
afshin opened this issue Aug 8, 2022 · 0 comments
Open

Improve Lumino cross-compatiblity with React #334

afshin opened this issue Aug 8, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@afshin
Copy link
Member

afshin commented Aug 8, 2022

@jasongrout recently brought up the point that by depending on React in @phosphor/widgets, we would have to bump the major version of our library when React has a major version bump. The TypeScript definitions for React have also been historically brittle. In JupyterLab, we have been forced to declare the types as a pinned dependency.

I think instead we should make it easier to use React with Phosphor.

  • Add the RenderWidget
  • Utilize the fact that jsx can now be declared per module in TypeScript
  • Add a pass through for React renderers to the Phosphor vdom
  • Add examples of using React in a Phosphor widget and vice versa.
  • Investigate allowing React components to be used as the renderers for the core Phosphor widgets.

Originally posted by @blink1073 in phosphorjs/phosphor#302 (comment)

@afshin afshin added the enhancement New feature or request label Aug 8, 2022
@afshin afshin added this to the Lumino 2 milestone Aug 8, 2022
@afshin afshin added this to Lumino 2 Aug 8, 2022
@afshin afshin moved this to Todo in Lumino 2 Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: not started
Development

No branches or pull requests

1 participant