Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

long line made even longer #386

Open
DavHau opened this issue Mar 26, 2023 · 0 comments
Open

long line made even longer #386

DavHau opened this issue Mar 26, 2023 · 0 comments
Labels
component | style Modifications to the formatting rules roadmap | long lines roadmap | style config status | it is a good thing We agree it is good to implement this type | feature request New feature or request

Comments

@DavHau
Copy link

DavHau commented Mar 26, 2023

Alejandra 3.0.0

input:

{
  buildersBySubsystem.${cfg.subsystem}.default =
    import (../../../../.. + "/src/subsystems/${cfg.subsystem}/builders/${cfg.builder}/default.nix") {
      inherit lib pkgs utils;
      dlib = {};
    };
}

output:

{
  buildersBySubsystem.${cfg.subsystem}.default = import (../../../../.. + "/src/subsystems/${cfg.subsystem}/builders/${cfg.builder}/default.nix") {
    inherit lib pkgs utils;
    dlib = {};
  };
}
abstrnoah added a commit to abstrnoah/dotfiles that referenced this issue Apr 12, 2024
@abstrnoah
try out alejandra formatter
8112768 
flake.nix is formatted with alejandra in this commit

My main concerns:
* Is the project being maintained? Last commit 7 months ago.
* let blocks kamadorueda/alejandra#257
* Output depends on whether closing bracket is on a newline... Imho,
  the output should depend exclusively on semantics and have nothing to
  do with aesthetic choices like indentation and placement of brackets.
* Things like kamadorueda/alejandra#386

Really, the second concern is the primary deal-breaker for me.
@kamadorueda kamadorueda added roadmap | long lines type | feature request New feature or request component | style Modifications to the formatting rules status | it is a good thing We agree it is good to implement this roadmap | style config labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component | style Modifications to the formatting rules roadmap | long lines roadmap | style config status | it is a good thing We agree it is good to implement this type | feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavHau @kamadorueda