Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single and double quotes problem in translations #4

Open
neonturk opened this issue Sep 11, 2024 · 6 comments
Open

Single and double quotes problem in translations #4

neonturk opened this issue Sep 11, 2024 · 6 comments

Comments

@neonturk
Copy link

neonturk commented Sep 11, 2024

Hello,
First of all, thank you for this nice package.

When I do the translation process, I see that additional double quotes are added in the translation file.

My language file;
<?php return [ 'singular' => 'Attribute', 'plural' => 'Attributes', ];

The translated file;

<?php return array ( 'singular' => '"Özellik"', 'plural' => '"Özellikler"', );

Other

My language file;

<?php return [ 'singular' => 'Attribute', 'plural' => 'Attribute\'s <i class="fa fa-long-arrow-right"></i> :button ', ];

The translated file;

<?php return array ( 'singular' => '"Özellik"', 'plural' => '"Özellik" <i class="fa fa-long-arrow-right"></i> :button ', );

EN to TR Translation
'model' => 'gpt-4o-mini',

Php Version: php8.1.13/
Laravel Version : Laravel Framework 9.52.16

@neonturk
Copy link
Author

The problem may be that the relevant translated text is directly placed in quotation marks.

@randyesperben
Copy link

randyesperben commented Oct 24, 2024

Hi! have the same problema. Did you found any solution?

Thanks!

EDIT: the problem seems to be the model. Using 4o works ok.

@neonturk
Copy link
Author

Hi! have the same problema. Did you found any solution?

Thanks!

EDIT: the problem seems to be the model. Using 4o works ok.

Yes, I use o4-mini. Because it is cheap and logical.
I have found a solution for the relevant problem and sent a merge request to the package owner, but he has not responded yet.

@randyesperben
Copy link

Great!

I've this error now, may you would know why?

Failed to translate the string. The keys are not matched. (Diff: reset-password, reset-password.expire-in, reset-password.message, reset-password.no-action-required, reset-password.trouble-clicking, subscription.invoice-payment-failed, subscription.invoice-payment-failed.fix-problem, subscription.invoice-payment-failed.message, subscription.invoice-payment-failed.message-2, subscription.invoice-payment-failed.sincerely, subscription.invoice-payment-failed.support-team, subscription.subscribed, subscription.subscribed.feedback, subscription.subscribed.message, subscription.subscribed.sincerely, subscription.subscribed.support-team, subscription.subscription-cancelled, subscription.subscription-cancelled.change-mind, subscription.subscription-cancelled.message, subscription.subscription-cancelled.message-2, subscription.subscription-cancelled.sincerely, subscription.subscription-cancelled.support-team, verify-email, verify-email.check-email, verify-email.if-not-received, verify-email.message, verify-email.please-check-email, verify-email.send-another-verification-email, verify-email.trouble-clicking, verify-email.verify-email-address)

@randyesperben
Copy link

this is mi lang file that gives me the error, I don't understand why?

'reset.password' => 'Restablece tu contraseña', 'reset.password.message' => 'Estás recibiendo este correo electrónico porque hemos recibido una solicitud de restablecimiento de contraseña para tu cuenta.', 'reset.password.expire-in' => 'Este enlace de restablecimiento de contraseña expirará en :minutes minutos.', 'reset.password.no-action-required' => 'Si no solicitaste un restablecimiento de contraseña, no se requiere ninguna acción adicional.', 'resetpassword.trouble-clicking' => 'Si tienes problemas para hacer clic en el enlace, copia y pega la URL en tu navegador:',

@neonturk
Copy link
Author

this is mi lang file that gives me the error, I don't understand why?

'reset.password' => 'Restablece tu contraseña', 'reset.password.message' => 'Estás recibiendo este correo electrónico porque hemos recibido una solicitud de restablecimiento de contraseña para tu cuenta.', 'reset.password.expire-in' => 'Este enlace de restablecimiento de contraseña expirará en :minutes minutos.', 'reset.password.no-action-required' => 'Si no solicitaste un restablecimiento de contraseña, no se requiere ninguna acción adicional.', 'resetpassword.trouble-clicking' => 'Si tienes problemas para hacer clic en el enlace, copia y pega la URL en tu navegador:',

Unfortunately I have no knowledge on the subject. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants