Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After deleting the cluster, also need to delete related metrics label. #5843

Open
CharlesQQ opened this issue Nov 20, 2024 · 3 comments · May be fixed by #5866
Open

After deleting the cluster, also need to delete related metrics label. #5843

CharlesQQ opened this issue Nov 20, 2024 · 3 comments · May be fixed by #5866
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@CharlesQQ
Copy link
Contributor

CharlesQQ commented Nov 20, 2024 •
edited
Loading

What happened:
After member cluster is deleted from karmada, the metrics label cluster_name for this cluster not deleted at the same

What you expected to happen:
when cluster deleted, remove deleted this cluster_name label value

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Karmada version:
  • kubectl-karmada or karmadactl version (the result of kubectl-karmada version or karmadactl version):
  • Others:
@CharlesQQ CharlesQQ added the kind/bug Categorizes issue or PR as related to a bug. label Nov 20, 2024
@RainbowMango
Copy link
Member

RainbowMango commented Nov 20, 2024 •
edited
Loading

Which metric you are talking about?
Similar to #5839?

@CharlesQQ
Copy link
Contributor Author

CharlesQQ commented Nov 20, 2024 •
edited
Loading

Which metric you are talking about?

I find some metrics:

  • cluster_ready_state
  • cluster_node_number
  • cluster_pod_allocated_number

@LavredisG
Copy link
Contributor

Same issue as #5839.

@RainbowMango RainbowMango mentioned this issue Nov 20, 2024
Closed
@CharlesQQ CharlesQQ linked a pull request Nov 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Karmada Overall Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cluster): remove raleted metrics label when cluster is deleted CharlesQQ/karmada
3 participants
@RainbowMango @CharlesQQ @LavredisG