Skip to content

Commit

Permalink
Merge pull request #3219 from alingse/fix-nilness-err
Browse files Browse the repository at this point in the history
🐛 fix check `deleteError != nil` but return an other nil value `err`
  • Loading branch information
kcp-ci-bot authored Dec 16, 2024
2 parents 718bcb2 + d1da7a5 commit 95838e4
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ func (c *Controller) deleteAllCR(ctx context.Context, clusterName logicalcluster

deleteError := utilerrors.NewAggregate(deleteErrors)
if deleteError != nil {
return gvrDeletionMetadata{}, err
return gvrDeletionMetadata{}, deleteError
}

// resource will not be delete immediately, instead of list again, we just return the
Expand Down

0 comments on commit 95838e4

Please sign in to comment.