Create build workflow #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feels unnecessarily verbose, but github apparently sets -e for these blocks, and working around that is harder and more verbose than this.
This is very annoying, but once again Github seems to make an ass of me by helpfully causing everything to parse in the exact way I want it not to.
Not sure why this is trying to add in extra stuff here... This commit fixes kenellorando#252.
This is no longer needed because there is no longer an extra -t being added if there are no tags on release. It didn't work originally anyway if a commit had multiple tags...
za419
commented
Aug 1, 2024
| if: env.push == 'true' | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| username: ${{ secrets.DOCKER_USERNAME }} |
There was a problem hiding this comment.
These secrets will need to be added to this repository for this bit to work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker images will be built on any update to a pull request, on any push to main (including merges), on the publication of a new release, or when requested manually.
Docker images will then be pushed for any of those conditions except PRs or manual requests that do not explicitly request pushes.
Images will always be tagged with the short ID of the current commit. Manual runs can set whatever tags they like - Automatic runs will add 'latest', and the name of any tags pointing to the current commit (which is why this runs on release, to get the new tag). All of these tags will be pushed to Docker, should pushing occur.
Merging this PR will fix #252.