Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl + F for diagrams #167

Open
soerendomroes opened this issue Feb 7, 2024 · 1 comment
Open

Ctrl + F for diagrams #167

soerendomroes opened this issue Feb 7, 2024 · 1 comment
Labels

Comments

@soerendomroes
Copy link
Member

Why bother with finding the best algorithm to create a readable diagram with labels that are big enough to read to be able to find everything if one can just search it.

It needs to be evaluated whether we can directly do a string search in the DOM and how this interacts with filtering techniques such as smart zoom. Just searching in the text and when highlighting or zooming into the corresponding diagram element might also be possible.

If we do this, we should carefully consider the different interaction techniques and how this can be integrated into VS Code and the cli tool at the same time without reimplementing all search features one usually has in these tools.

@NiklasRentzCAU
Copy link
Member

Ctrl+F does work in the CLI, it uses the default browser implementation and searches for text in the DOM. However, this means that

  1. It does not work together with smart zoom. When an element is off-screen or hidden because of readability, it cannot be searched.
  2. it does not zoom/pan to the searched element, the default browser implementation would only use the default browser scroll to to to the highlighted element, which is not what Sprotty does. We would need a pan if offscreen and maybe a zoom if the element is too small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants