Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: add a way to dynamically set the kakarot block gas limit in the hive chain binary #838

Open
Eikix opened this issue Mar 7, 2024 · 7 comments
Open

dev: add a way to dynamically set the kakarot block gas limit in the hive chain binary #838

Eikix opened this issue Mar 7, 2024 · 7 comments
Labels
enhancement Enhancement of the code, not introducing new features.

Comments

@Eikix
Copy link
Member

Eikix commented Mar 7, 2024

#833 (comment)
@Eikix Eikix added the enhancement Enhancement of the code, not introducing new features. label Mar 7, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Mar 7, 2024
anukkrit149 pushed a commit to karnotxyz/kakarot-rpc that referenced this issue Aug 9, 2024
@greged93
fix timestamp (kkrt-labs#838)
55dd637 
<!--- Please provide a general summary of your changes in the title
above -->

<!-- Give an estimate of the time you spent on this PR in terms of work
days.
Did you spend 0.5 days on this PR or rather 2 days?  -->

Time spent on this PR: 0.1 day

## Pull request type

<!-- Please try to limit your pull request to one type,
submit multiple pull requests if needed. -->

Please check the type of change your PR introduces:

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?
The timestamp for anvil is set to the genesis block timestamp.

<!-- Please describe the current behavior that you are modifying,
or link to a relevant issue. -->

Resolves #NA

## What is the new behavior?
Set the timestamp to the current block timestamp.
@greged93
Copy link
Contributor

greged93 commented Oct 1, 2024

@Eikix this needs scoping

@Eikix
Copy link
Member Author

Eikix commented Oct 2, 2024

@Eikix this needs scoping

I don't remember the context / need; are you able to scope this issue if it is still needed?

@greged93
Copy link
Contributor

greged93 commented Oct 2, 2024

The idea is that we don't have a way to set the gas limit in the contract dynamically, meaning it will just be fixed to a certain value, without taking into account L1 gas fluctuations. The initial idea was to have a service update this value but this was never further scoped

@Eikix
Copy link
Member Author

Eikix commented Oct 2, 2024

The idea is that we don't have a way to set the gas limit in the contract dynamically, meaning it will just be fixed to a certain value, without taking into account L1 gas fluctuations. The initial idea was to have a service update this value but this was never further scoped

What does it unlock that is currently locked? Test accuracy? Some tests fail because of it?

@greged93
Copy link
Contributor

greged93 commented Oct 2, 2024

No just better transaction cost on chain. If you don't do this and we charge a base fee of 1 Gwei while L1 cost is 1000Gwei, it will cause a big missprice between the Starknet cost the relayer pays on Sepolia and the actual cost which is paid to the coinbase.

@Eikix
Copy link
Member Author

Eikix commented Oct 2, 2024

But this is for hive chain binary

@greged93
Copy link
Contributor

greged93 commented Oct 2, 2024

oh my bad, then is more a tracking issue then, in case we ever need to dynamically set the block gas limit in the hive tests. For now since hive tests are locked to a specific commit because of this issue, there is nothing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
No open projects
Kakarot on Starknet
Status: 🆕 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Eikix @greged93