Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broker Spec Link broken #4942

Closed
embano1 opened this issue Apr 27, 2022 · 3 comments
Closed

Broker Spec Link broken #4942

embano1 opened this issue Apr 27, 2022 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/eventing priority/medium triage/needs-eng-input Engineering input is requested

Comments

@embano1
Copy link
Contributor

embano1 commented Apr 27, 2022

This link is broken:

docs/docs/eventing/broker/README.md

Line 55 in a3af111

- View the [broker specifications](https://github.com/knative/specs/blob/main/specs/eventing/broker.md).

Question: should it point to https://github.com/knative/specs/blob/main/specs/eventing/overview.md#broker since broker.md does not exist anymore?
@abrennan89 abrennan89 added kind/bug Categorizes issue or PR as related to a bug. triage/needs-eng-input Engineering input is requested kind/eventing priority/medium labels May 25, 2022
@antoineco
Copy link
Contributor

antoineco commented May 27, 2022 •
edited
Loading

Addressed in #4970.
Rationale for the new link: broker.md was merged in knative/specs#25 with control-plane.md.

@antoineco
Copy link
Contributor

/close

@knative-prow
Copy link

knative-prow bot commented May 27, 2022

@antoineco: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot closed this as completed May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/eventing priority/medium triage/needs-eng-input Engineering input is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@antoineco @embano1 @abrennan89