Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestReply: Create InitContainer #8320

Open
Cali0707 opened this issue Nov 11, 2024 · 6 comments
Open

RequestReply: Create InitContainer #8320

Cali0707 opened this issue Nov 11, 2024 · 6 comments
Assignees
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@Cali0707
Copy link
Member

Problem
Since the RequestReply resource needs a trigger to every pod, rather than to the deployment as a whole, we need to create an InitContainer which creates the trigger to the current pod. The trigger should look like:

apiVersion: eventing.knative.dev/v1
kind: Trigger
metadata:
  name: <generated name>
  namespace: <pod namespace>
spec:
  brokerRef: <brokerRef from the RequestReply resource>
  subscriber: <the RequestReply deployment>
  triggers:
    - cesql: "EXISTS <the name of the replyid for the RequestReply resource> AND KN_VERIFY_CORRELATION_ID(<the name of the replyid for the RequestReply resource>, <the secret names for the resource listed out>)"

Persona:
Which persona is this feature for?

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.

@chaliuu
Copy link

chaliuu commented Nov 13, 2024

/assign

@Cali0707
Copy link
Member Author

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Nov 21, 2024
@KapilSareen
Copy link

Hi @Cali0707, @chaliuu, is anyone currently working on this issue? If not, I’d love to contribute!

@Cali0707
Copy link
Member Author

Hey @KapilSareen I believe @chaliuu is still working on this

@chaliuu
Copy link

chaliuu commented Dec 11, 2024

Hi yea sorry still working on this

@KapilSareen
Copy link

Hi @chaliuu, I’d love to collaborate on this issue if you’re interested. I’ve been trying to grasp some related concepts, and I believe working on this together could be really helpful. Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

3 participants