Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop and turn off QPS and Burst setting #2756

Open
nak3 opened this issue Jun 16, 2023 · 5 comments
Open

Drop and turn off QPS and Burst setting #2756

nak3 opened this issue Jun 16, 2023 · 5 comments
Labels
area/API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@nak3
Copy link
Contributor

nak3 commented Jun 16, 2023

/area API
/kind cleanup

Please refer to #2755 (comment)

Upstream recommends that we should turn off it and use APF instead.

@knative-prow knative-prow bot added area/API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 16, 2023
@pierDipi
Copy link
Member

If we do this, I'd advise to coordinate with working groups if we plan to make breaking changes in this area, it seems we're suggesting to turn them off but that is only a partial solution.

I would actually suggest to allow turning them off but as opt-out config

@nak3
Copy link
Contributor Author

nak3 commented Jun 16, 2023

I got an advice from internal team that disabling client-side rate-limiting is a GA goal of APF.

https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/1040-priority-and-fairness/README.md#graduation-criteria

APF allows us to disable client-side rate limiting without causing the apiservers to wedge/crash.

And there are still some efforts like kubernetes/kubernetes#109614

So yes, we should take care this carefully or actually we can just wait for GA of APF.

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2023
@dprotaso
Copy link
Member

/lifecycle frozen

@knative-prow knative-prow bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 15, 2023
@dprotaso
Copy link
Member

We should revisit this once our serving perf changes lands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants