Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated messages on same host #7

Open
mrkeuz opened this issue Mar 22, 2022 · 6 comments
Open

Duplicated messages on same host #7

mrkeuz opened this issue Mar 22, 2022 · 6 comments

Comments

@mrkeuz
Copy link

mrkeuz commented Mar 22, 2022

Again! Really fun project! 🚀🚀🚀

If you run two instances on same host you receive duplicated messages (ONLY on receiver side)

image

Env

cargo +nightly build
cargo 1.60.0-nightly (95bb3c92b 2022-01-18)
Ubuntu 20.04.4 5.4.0-104-generic

@kognise
Copy link
Owner

kognise commented Mar 22, 2022

I can't seem to reproduce this, but I fixed it by deduplicating messages by id in 8e22e48 which should wipe away this whole class of issues. Gonna make a new release in a couple minutes.

@kognise
Copy link
Owner

kognise commented Mar 22, 2022

@kognise kognise closed this as completed Mar 22, 2022
@mrkeuz
Copy link
Author

mrkeuz commented Mar 23, 2022

Confirm! Worked as expected on latest 5174daf 🚀🚀🚀

@mrkeuz
Copy link
Author

mrkeuz commented Mar 23, 2022

@kognise hi again, I understand that it's just fun project, and I'm NOT expected to fix, REALLY.

Just FYI, found several issues:

  • History not show messages that I sent from machine
  • Sometimes users not detected but still receive messages as [unknown]. I've tried restart client - not help. Client that start FIRST not receive user list.
  • At start, messages not deliver at all (couple messages or there is some timeout, I don't get it)

Notes:

  • I run it on Linux → Linux (via Wi-Fi)

  • In Wireshark messages are seems appearing . Can send pcap file to you, by email, if needed (just not want share mac addresses here). Just let me know.
    Here warm-up clients:

    image

image

@kognise
Copy link
Owner

kognise commented Mar 23, 2022

hmm, that's weird! the implication is that some packets just aren't going through - i don't know if it's an issue of them being mutilated, or if they're just being dropped. could you open arpchat on only one device, reproduce one of the issues, and send me a pcap file from that device? if you'd prefer to email it, you can send to hi@kognise.dev.

if the problem is that the packets are being dropped i could try implementing some retry mechanism but it'll be a bit before i feel like doing something like that. in the meantime i am curious what the issue is :)

@kognise kognise reopened this Mar 23, 2022
@mrkeuz
Copy link
Author

mrkeuz commented Mar 23, 2022

What I found, on lo interface all ok. History working, all clients displayed correctly.

image

BUT if you choose wlan/eth0 (both clients runs locally) issue reproduced as described above.

  • Comparing pcaps (lo vs wlan/eth0) seems ARP packets drops/filtered on wlan by some reason ((( Also not see any criminal rules about in iptables, ufw or on router (not sure how arp packets sending in core). Don't know where to dig after. Tested on two machines Ubuntu + Raspbian. Same behavior.
  • sudo does not help (I thought maybe not enough some network permission)
  • pcap details sent to email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants