Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support generator function as command action #819

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Anillc
Copy link
Member

@Anillc Anillc commented Oct 16, 2022

支持将 generator 传入 action 中

由于 microsoft/TypeScript#51187, 类型推断暂时并不能很好地工作

另外有待讨论的是 next 中传入一个 Promise<string[]>。相关 issue microsoft/TypeScript#44808

由于 arrow generator 还在 stage 1, 这个用法可能还不够优雅

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Base: 92.25% // Head: 92.39% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (3a873d3) compared to base (e017de8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
+ Coverage   92.25%   92.39%   +0.14%     
==========================================
  Files          60       60              
  Lines        6582     6605      +23     
  Branches     1276     1285       +9     
==========================================
+ Hits         6072     6103      +31     
+ Misses        510      502       -8     
Impacted Files Coverage Δ
packages/core/src/command/command.ts 96.70% <100.00%> (+0.19%) ⬆️
packages/utils/src/misc.ts 72.91% <100.00%> (+2.46%) ⬆️
plugins/mock/src/client.ts 100.00% <0.00%> (+7.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shigma shigma changed the title Generator action feat(core): support generator function as command action Oct 21, 2022
@purerosefallen
Copy link
Member

How about RxJS observables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants