From d40abe24e529c66b2c6336078f11a39e425c6b3f Mon Sep 17 00:00:00 2001 From: Jakub Kolebaba Date: Tue, 27 Sep 2022 15:09:23 +1000 Subject: [PATCH] Fix Marker rendering in strict mode (#471) --- src/Marker.tsx | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/Marker.tsx b/src/Marker.tsx index dbaf255..3a3f816 100644 --- a/src/Marker.tsx +++ b/src/Marker.tsx @@ -54,21 +54,22 @@ const Marker = (props: MarkerProps) => { sMarker.decorate(window.SMap.Marker.Feature.Card, card); }; - const {lng, lat} = props.coords; + const { lng, lat } = props.coords; const coords = window.SMap.Coords.fromWGS84(lng, lat); const options = resolveOptions(); const sMarker = new window.SMap.Marker(coords, props.id, options); - markerLayer?.addMarker(sMarker); - - if (props.card) { - renderCard(); - } useEffect(() => { + markerLayer?.addMarker(sMarker); + + if (props.card) { + renderCard(); + } + return () => { markerLayer.removeMarker(sMarker, true); }; - }); + }, []); return null; };